From: Umang Jain <umang.jain@ideasonboard.com>
To: Stefan Wahren <wahrenst@gmx.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Florian Fainelli <florian.fainelli@broadcom.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-staging@lists.linux.dev,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/4] staging: vchiq_core: Add missing blank lines
Date: Sun, 21 Apr 2024 14:25:47 +0530 [thread overview]
Message-ID: <5420a612-15a3-4d37-9281-b59a92364ec8@ideasonboard.com> (raw)
In-Reply-To: <20240420115351.27713-5-wahrenst@gmx.net>
Hi Stefan,
Thank you for the patch
On 20/04/24 5:23 pm, Stefan Wahren wrote:
> checkpatch.pl noticed about missing blank line after 2 declarations.
> So add them for better readability.
>
> Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
> ---
> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
> index ca32902afe06..df3af821f218 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
> @@ -227,6 +227,7 @@ struct vchiq_service *handle_to_service(struct vchiq_instance *instance, unsigne
>
> return rcu_dereference(instance->state->services[idx]);
> }
> +
> struct vchiq_service *
> find_service_by_handle(struct vchiq_instance *instance, unsigned int handle)
> {
> @@ -2176,6 +2177,7 @@ vchiq_init_state(struct vchiq_state *state, struct vchiq_slot_zero *slot_zero, s
>
> for (i = 0; i < VCHIQ_MAX_SERVICES; i++) {
> struct vchiq_service_quota *quota = &state->service_quotas[i];
> +
> init_completion("a->quota_event);
> }
>
> --
> 2.34.1
>
prev parent reply other threads:[~2024-04-21 8:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-20 11:53 [PATCH 0/4] staging: vchiq_core: Minor clean-ups Stefan Wahren
2024-04-20 11:53 ` [PATCH 1/4] staging: vchiq_core: Use printk messages for devices Stefan Wahren
2024-04-21 8:53 ` Umang Jain
2024-04-20 11:53 ` [PATCH 2/4] staging: vchiq_core: Add parentheses to VCHIQ_MSG_SRCPORT Stefan Wahren
2024-04-21 8:54 ` Umang Jain
2024-04-20 11:53 ` [PATCH 3/4] staging: vchiq_core: Drop unnecessary blank lines Stefan Wahren
2024-04-21 8:55 ` Umang Jain
2024-04-20 11:53 ` [PATCH 4/4] staging: vchiq_core: Add missing " Stefan Wahren
2024-04-21 8:55 ` Umang Jain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5420a612-15a3-4d37-9281-b59a92364ec8@ideasonboard.com \
--to=umang.jain@ideasonboard.com \
--cc=florian.fainelli@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).