From: Umang Jain <umang.jain@ideasonboard.com>
To: Stefan Wahren <wahrenst@gmx.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Florian Fainelli <florian.fainelli@broadcom.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-staging@lists.linux.dev,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/4] staging: vchiq_core: Use printk messages for devices
Date: Sun, 21 Apr 2024 14:23:54 +0530 [thread overview]
Message-ID: <6b83abcf-5cb1-4e61-b839-b4d51abda18a@ideasonboard.com> (raw)
In-Reply-To: <20240420115351.27713-2-wahrenst@gmx.net>
Hi Stefan,
Thank you for the patch
On 20/04/24 5:23 pm, Stefan Wahren wrote:
> Now that struct vchiq_state has a device reference, we can convert
> the remaining printk message helpers.
>
> Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
> ---
> .../vc04_services/interface/vchiq_arm/vchiq_core.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
> index 3397365e551e..129d73fec2bf 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
> @@ -697,7 +697,8 @@ reserve_space(struct vchiq_state *state, size_t space, int is_blocking)
>
> if (tx_pos == (state->slot_queue_available * VCHIQ_SLOT_SIZE)) {
> complete(&state->slot_available_event);
> - pr_warn("%s: invalid tx_pos: %d\n", __func__, tx_pos);
> + dev_warn(state->dev, "%s: invalid tx_pos: %d\n",
> + __func__, tx_pos);
> return NULL;
> }
>
> @@ -1732,10 +1733,9 @@ parse_message(struct vchiq_state *state, struct vchiq_header *header)
> break;
> }
> if (queue->process != queue->remote_insert) {
> - pr_err("%s: p %x != ri %x\n",
> - __func__,
> - queue->process,
> - queue->remote_insert);
> + dev_err(state->dev, "%s: p %x != ri %x\n",
> + __func__, queue->process,
> + queue->remote_insert);
> mutex_unlock(&service->bulk_mutex);
> goto bail_not_ready;
> }
> --
> 2.34.1
>
next prev parent reply other threads:[~2024-04-21 8:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-20 11:53 [PATCH 0/4] staging: vchiq_core: Minor clean-ups Stefan Wahren
2024-04-20 11:53 ` [PATCH 1/4] staging: vchiq_core: Use printk messages for devices Stefan Wahren
2024-04-21 8:53 ` Umang Jain [this message]
2024-04-20 11:53 ` [PATCH 2/4] staging: vchiq_core: Add parentheses to VCHIQ_MSG_SRCPORT Stefan Wahren
2024-04-21 8:54 ` Umang Jain
2024-04-20 11:53 ` [PATCH 3/4] staging: vchiq_core: Drop unnecessary blank lines Stefan Wahren
2024-04-21 8:55 ` Umang Jain
2024-04-20 11:53 ` [PATCH 4/4] staging: vchiq_core: Add missing " Stefan Wahren
2024-04-21 8:55 ` Umang Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b83abcf-5cb1-4e61-b839-b4d51abda18a@ideasonboard.com \
--to=umang.jain@ideasonboard.com \
--cc=florian.fainelli@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).