From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Wan Jiabing <wanjiabing@vivo.com>
Cc: Fabio Aiuto <fabioaiuto83@gmail.com>,
Marco Cesati <marcocesati@gmail.com>,
Jiabing Wan <kael_w@yeah.net>, Ivan Safonov <insafonov@gmail.com>,
Ross Schmidt <ross.schm.dev@gmail.com>,
Colin Ian King <colin.king@canonical.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: os_dep: Align comments and add a blank line
Date: Wed, 19 May 2021 17:50:20 +0200 [thread overview]
Message-ID: <YKUzvHg+m66d0v5x@kroah.com> (raw)
In-Reply-To: <20210518022207.83513-1-wanjiabing@vivo.com>
On Tue, May 18, 2021 at 10:20:54AM +0800, Wan Jiabing wrote:
> From: Jiabing Wan <kael_w@yeah.net>
>
> Fixing the following checkpatch warnings:
> WARNING: Block comments should align the * on each line
> WARNING: Missing a blank line after declarations
>
> Signed-off-by: Jiabing Wan<kael_w@yeah.net>
> ---
> drivers/staging/rtl8723bs/os_dep/osdep_service.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/os_dep/osdep_service.c b/drivers/staging/rtl8723bs/os_dep/osdep_service.c
> index c58555a4012f..2d965e62347f 100644
> --- a/drivers/staging/rtl8723bs/os_dep/osdep_service.c
> +++ b/drivers/staging/rtl8723bs/os_dep/osdep_service.c
> @@ -7,10 +7,10 @@
> #include <drv_types.h>
> #include <rtw_debug.h>
>
> -/*
> -* Translate the OS dependent @param error_code to OS independent RTW_STATUS_CODE
> -* @return: one of RTW_STATUS_CODE
> -*/
> +/**
If you are going to use kernel doc, make it kernel doc, don't just make
it half-way there :)
> + * Translate the OS dependent @param error_code to OS independent RTW_STATUS_CODE
> + * @return: one of RTW_STATUS_CODE
> + */
> inline int RTW_STATUS_CODE(int error_code)
> {
> if (error_code >= 0)
> @@ -262,6 +262,7 @@ bool rtw_cbuf_push(struct rtw_cbuf *cbuf, void *buf)
> void *rtw_cbuf_pop(struct rtw_cbuf *cbuf)
> {
> void *buf;
> +
> if (rtw_cbuf_empty(cbuf))
> return NULL;
>
> --
> 2.20.1
>
You are doing multiple things in the same patch, please break this up.
thanks,
greg k-h
prev parent reply other threads:[~2021-05-19 15:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 2:20 [PATCH] staging: rtl8723bs: os_dep: Align comments and add a blank line Wan Jiabing
2021-05-19 15:50 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKUzvHg+m66d0v5x@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=colin.king@canonical.com \
--cc=fabioaiuto83@gmail.com \
--cc=insafonov@gmail.com \
--cc=kael_w@yeah.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=marcocesati@gmail.com \
--cc=ross.schm.dev@gmail.com \
--cc=wanjiabing@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).