* [PATCH] staging: rtl8723bs: os_dep: Align comments and add a blank line
@ 2021-05-18 2:20 Wan Jiabing
2021-05-19 15:50 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Wan Jiabing @ 2021-05-18 2:20 UTC (permalink / raw)
To: Greg Kroah-Hartman, Fabio Aiuto, Marco Cesati, Jiabing Wan,
Ivan Safonov, Ross Schmidt, Colin Ian King, linux-staging,
linux-kernel
From: Jiabing Wan <kael_w@yeah.net>
Fixing the following checkpatch warnings:
WARNING: Block comments should align the * on each line
WARNING: Missing a blank line after declarations
Signed-off-by: Jiabing Wan<kael_w@yeah.net>
---
drivers/staging/rtl8723bs/os_dep/osdep_service.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/osdep_service.c b/drivers/staging/rtl8723bs/os_dep/osdep_service.c
index c58555a4012f..2d965e62347f 100644
--- a/drivers/staging/rtl8723bs/os_dep/osdep_service.c
+++ b/drivers/staging/rtl8723bs/os_dep/osdep_service.c
@@ -7,10 +7,10 @@
#include <drv_types.h>
#include <rtw_debug.h>
-/*
-* Translate the OS dependent @param error_code to OS independent RTW_STATUS_CODE
-* @return: one of RTW_STATUS_CODE
-*/
+/**
+ * Translate the OS dependent @param error_code to OS independent RTW_STATUS_CODE
+ * @return: one of RTW_STATUS_CODE
+ */
inline int RTW_STATUS_CODE(int error_code)
{
if (error_code >= 0)
@@ -262,6 +262,7 @@ bool rtw_cbuf_push(struct rtw_cbuf *cbuf, void *buf)
void *rtw_cbuf_pop(struct rtw_cbuf *cbuf)
{
void *buf;
+
if (rtw_cbuf_empty(cbuf))
return NULL;
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: rtl8723bs: os_dep: Align comments and add a blank line
2021-05-18 2:20 [PATCH] staging: rtl8723bs: os_dep: Align comments and add a blank line Wan Jiabing
@ 2021-05-19 15:50 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2021-05-19 15:50 UTC (permalink / raw)
To: Wan Jiabing
Cc: Fabio Aiuto, Marco Cesati, Jiabing Wan, Ivan Safonov,
Ross Schmidt, Colin Ian King, linux-staging, linux-kernel
On Tue, May 18, 2021 at 10:20:54AM +0800, Wan Jiabing wrote:
> From: Jiabing Wan <kael_w@yeah.net>
>
> Fixing the following checkpatch warnings:
> WARNING: Block comments should align the * on each line
> WARNING: Missing a blank line after declarations
>
> Signed-off-by: Jiabing Wan<kael_w@yeah.net>
> ---
> drivers/staging/rtl8723bs/os_dep/osdep_service.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/os_dep/osdep_service.c b/drivers/staging/rtl8723bs/os_dep/osdep_service.c
> index c58555a4012f..2d965e62347f 100644
> --- a/drivers/staging/rtl8723bs/os_dep/osdep_service.c
> +++ b/drivers/staging/rtl8723bs/os_dep/osdep_service.c
> @@ -7,10 +7,10 @@
> #include <drv_types.h>
> #include <rtw_debug.h>
>
> -/*
> -* Translate the OS dependent @param error_code to OS independent RTW_STATUS_CODE
> -* @return: one of RTW_STATUS_CODE
> -*/
> +/**
If you are going to use kernel doc, make it kernel doc, don't just make
it half-way there :)
> + * Translate the OS dependent @param error_code to OS independent RTW_STATUS_CODE
> + * @return: one of RTW_STATUS_CODE
> + */
> inline int RTW_STATUS_CODE(int error_code)
> {
> if (error_code >= 0)
> @@ -262,6 +262,7 @@ bool rtw_cbuf_push(struct rtw_cbuf *cbuf, void *buf)
> void *rtw_cbuf_pop(struct rtw_cbuf *cbuf)
> {
> void *buf;
> +
> if (rtw_cbuf_empty(cbuf))
> return NULL;
>
> --
> 2.20.1
>
You are doing multiple things in the same patch, please break this up.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-19 15:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-18 2:20 [PATCH] staging: rtl8723bs: os_dep: Align comments and add a blank line Wan Jiabing
2021-05-19 15:50 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).