From: Alison Schofield <alison.schofield@intel.com>
To: Ayush Tiwari <ayushtiw0110@gmail.com>
Cc: Larry.Finger@lwfinger.net, florian.c.schilhabel@googlemail.com,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev, outreachy@lists.linux.dev
Subject: Re: [PATCH] staging: greybus: add comment for mutex
Date: Wed, 13 Mar 2024 19:32:20 -0700 [thread overview]
Message-ID: <ZfJhtBrsL3elRve8@aschofie-mobl2> (raw)
In-Reply-To: <ZfHuokO3pQXMOxcC@ayush-HP-Pavilion-Gaming-Laptop-15-ec0xxx>
On Wed, Mar 13, 2024 at 11:51:22PM +0530, Ayush Tiwari wrote:
> This patch adds descriptive comment to mutex within the struct
> gbaudio_codec_info to clarify its intended use and to address
> checkpatch checks.
Hi Ayush-
You may be right, but you need to convince your patch reviewers
why your comment accurately describes this mutex.
That's always the ask with this kind of patch.
BTW - Don't start your commit log with 'This patch...'.
Alison
>
> Signed-off-by: Ayush Tiwari <ayushtiw0110@gmail.com>
> ---
> drivers/staging/greybus/audio_codec.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/greybus/audio_codec.h b/drivers/staging/greybus/audio_codec.h
> index f3f7a7ec6be4..1f97d4fb16cd 100644
> --- a/drivers/staging/greybus/audio_codec.h
> +++ b/drivers/staging/greybus/audio_codec.h
> @@ -71,6 +71,7 @@ struct gbaudio_codec_info {
> /* to maintain runtime stream params for each DAI */
> struct list_head dai_list;
> struct mutex lock;
> + /* Lock to protect register access */
> struct mutex register_mutex;
> };
>
> --
> 2.40.1
>
>
next prev parent reply other threads:[~2024-03-14 2:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 18:21 [PATCH] staging: greybus: add comment for mutex Ayush Tiwari
2024-03-14 2:32 ` Alison Schofield [this message]
2024-03-14 7:37 ` Dan Carpenter
2024-03-14 14:57 ` Alison Schofield
2024-03-14 7:48 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZfJhtBrsL3elRve8@aschofie-mobl2 \
--to=alison.schofield@intel.com \
--cc=Larry.Finger@lwfinger.net \
--cc=ayushtiw0110@gmail.com \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).