From: Alison Schofield <alison.schofield@intel.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Ayush Tiwari <ayushtiw0110@gmail.com>,
Larry.Finger@lwfinger.net, florian.c.schilhabel@googlemail.com,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev, outreachy@lists.linux.dev
Subject: Re: [PATCH] staging: greybus: add comment for mutex
Date: Thu, 14 Mar 2024 07:57:48 -0700 [thread overview]
Message-ID: <ZfMQbIzZ6lKhxhkM@aschofie-mobl2> (raw)
In-Reply-To: <41239f06-596e-4c17-95ed-4bf06ba9f9ec@moroto.mountain>
On Thu, Mar 14, 2024 at 10:37:29AM +0300, Dan Carpenter wrote:
> On Wed, Mar 13, 2024 at 07:32:20PM -0700, Alison Schofield wrote:
> > On Wed, Mar 13, 2024 at 11:51:22PM +0530, Ayush Tiwari wrote:
> > > This patch adds descriptive comment to mutex within the struct
> > > gbaudio_codec_info to clarify its intended use and to address
> > > checkpatch checks.
> >
> > Hi Ayush-
> >
> > You may be right, but you need to convince your patch reviewers
> > why your comment accurately describes this mutex.
> >
> > That's always the ask with this kind of patch.
>
> Heh. Yeah. The comment wasn't right in this case. The lock has
> nothing to do with registers or register access.
>
> >
> > BTW - Don't start your commit log with 'This patch...'.
> >
>
> Outreachy folk are a more particular about some of this stuff than I am.
> Which is fine. Could you do me a favor though? Could you ack patches
> once you're happy with them?
Dan -
Sure. In practice, the patches are often 'Reviewed-by' someone else
by the time I get back around to it (thanks to the different time
zones and plentiful reviewers) But I understand, I'll make it a
habit of at Ack'ing after I've asked for something to change.
Alison
>
> regards,
> dan carpenter
>
next prev parent reply other threads:[~2024-03-14 14:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 18:21 [PATCH] staging: greybus: add comment for mutex Ayush Tiwari
2024-03-14 2:32 ` Alison Schofield
2024-03-14 7:37 ` Dan Carpenter
2024-03-14 14:57 ` Alison Schofield [this message]
2024-03-14 7:48 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZfMQbIzZ6lKhxhkM@aschofie-mobl2 \
--to=alison.schofield@intel.com \
--cc=Larry.Finger@lwfinger.net \
--cc=ayushtiw0110@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).