From: Fabio Aiuto <fabioaiuto83@gmail.com>
Cc: julia.lawall@inria.fr, joe@perches.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH 0/7] staging: rtl8723bs: replace DBG_871X_SEL_NL macro with netdev_dbg()
Date: Tue, 13 Apr 2021 16:10:35 +0200 [thread overview]
Message-ID: <cover.1618322367.git.fabioaiuto83@gmail.com> (raw)
This patchset replaces DGB_871X_SEL_NL macro with the driver
recommended log function netdev_dbg().
Macro DBG_871X_SEL_NL indeed executes a raw printk call as
default behaviour. The other behaviour is doing a seq_printf()
call which never occurs.
First patch replace dump_drv_version with a netdev_dbg() call.
Second patch remove an unnecessary dump_drv_version() usage.
Third patch removes dump_drv_version() now unused and
unused dump_log_level() as well
Fourth patch apply the following coccinelle script for macro
bulk replacement:
@@
expression sel;
expression list args;
identifier padapter;
identifier func;
@@
func(..., struct adapter *padapter, ...) {
<...
- DBG_871X_SEL_NL(sel, args);
+ netdev_dbg(padapter->pnetdev, args);
...>
}
@rule@
identifier func, context, padapter;
@@
func(void *context)
{
...
struct adapter *padapter = context;
...
}
@@
expression sel;
expression list args;
identifier rule.padapter;
identifier rule.func, rule.context;
@@
func(void *context)
{
<...
- DBG_871X_SEL_NL(sel, args);
+ netdev_dbg(padapter->pnetdev, args);
...>
}
@@
expression sel;
expression list args;
expression get_dev;
identifier func, dev;
@@
func(...)
{
...
struct net_device *dev = get_dev;
<...
- DBG_871X_SEL_NL(sel, args);
+ netdev_dbg(dev, args);
...>
}
@@
expression sel;
expression list args;
identifier func, dev;
@@
func(struct net_device *dev)
{
<...
- DBG_871X_SEL_NL(sel, args);
+ netdev_dbg(dev, args);
...>
}
@@
expression sel;
expression list args;
identifier func, dvobj;
@@
func(struct dvobj_priv *dvobj)
{
<...
- DBG_871X_SEL_NL(sel, args);
+ netdev_dbg(dvobj->if1->pnetdev, args);
...>
}
Fifth patch fixes a post commit checkpatch issue left
by coccinelle output.
Sixth patch removes DBG_871X_SEL_NL macro declaration.
Seventh patch removes an unused function argument after
macro replacement.
Fabio Aiuto (7):
staging: rtl8723bs: replace dump_drv_version usage with netdev_*
staging: rtl8723bs: remove unnecessary dump_drv_version() usage
staging: rtl8723bs: remove two unused functions
staging: rtl8723bs: replace DBG_871X_SEL_NL with netdev_dbg()
staging: rtl8723bs: put a new line after ';'
staging: rtl8723bs: remove DBG_871X_SEL_NL macro declaration
staging: rtl8723bs: remove unused argument in function
drivers/staging/rtl8723bs/core/rtw_debug.c | 26 +++-------
drivers/staging/rtl8723bs/core/rtw_odm.c | 52 ++++++++++---------
drivers/staging/rtl8723bs/hal/hal_com.c | 31 +++++------
drivers/staging/rtl8723bs/include/rtw_debug.h | 12 -----
drivers/staging/rtl8723bs/include/rtw_odm.h | 2 +-
.../staging/rtl8723bs/os_dep/ioctl_linux.c | 4 +-
drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 1 -
7 files changed, 51 insertions(+), 77 deletions(-)
--
2.20.1
next reply other threads:[~2021-04-13 14:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 14:10 Fabio Aiuto [this message]
2021-04-13 14:10 ` [PATCH 1/7] staging: rtl8723bs: replace dump_drv_version usage with netdev_* Fabio Aiuto
2021-04-13 14:10 ` [PATCH 2/7] staging: rtl8723bs: remove unnecessary dump_drv_version() usage Fabio Aiuto
2021-04-13 14:10 ` [PATCH 3/7] staging: rtl8723bs: remove two unused functions Fabio Aiuto
2021-04-13 14:10 ` [PATCH 4/7] staging: rtl8723bs: replace DBG_871X_SEL_NL with netdev_dbg() Fabio Aiuto
2021-04-13 14:10 ` [PATCH 5/7] staging: rtl8723bs: put a new line after ';' Fabio Aiuto
2021-04-13 14:10 ` [PATCH 6/7] staging: rtl8723bs: remove DBG_871X_SEL_NL macro declaration Fabio Aiuto
2021-04-13 14:10 ` [PATCH 7/7] staging: rtl8723bs: remove unused argument in function Fabio Aiuto
2021-04-13 14:14 ` [PATCH 0/7] staging: rtl8723bs: replace DBG_871X_SEL_NL macro with netdev_dbg() Fabio Aiuto
-- strict thread matches above, loose matches on Subject: below --
2021-04-13 14:56 Fabio Aiuto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1618322367.git.fabioaiuto83@gmail.com \
--to=fabioaiuto83@gmail.com \
--cc=joe@perches.com \
--cc=julia.lawall@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).