From: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Prashanth K <quic_prashk@quicinc.com>
Cc: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Wesley Cheng <quic_wcheng@quicinc.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH v2] usb: dwc3: Wait unconditionally after issuing EndXfer command
Date: Tue, 30 Apr 2024 22:59:58 +0000 [thread overview]
Message-ID: <20240430225955.e7g53uycd35hcql3@synopsys.com> (raw)
In-Reply-To: <2024043022-chatroom-backwash-371e@gregkh>
On Tue, Apr 30, 2024, Greg Kroah-Hartman wrote:
> On Thu, Apr 25, 2024 at 11:22:08PM +0000, Thinh Nguyen wrote:
> > On Thu, Apr 25, 2024, Prashanth K wrote:
> > > diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
> > > index 4df2661f6675..666eae94524f 100644
> > > --- a/drivers/usb/dwc3/gadget.c
> > > +++ b/drivers/usb/dwc3/gadget.c
> > > @@ -1724,8 +1724,7 @@ static int __dwc3_stop_active_transfer(struct dwc3_ep *dep, bool force, bool int
> > > dep->resource_index = 0;
> > >
> > > if (!interrupt) {
> > > - if (!DWC3_IP_IS(DWC3) || DWC3_VER_IS_PRIOR(DWC3, 310A))
> > > - mdelay(1);
> > > + mdelay(1);
> > > dep->flags &= ~DWC3_EP_TRANSFER_STARTED;
> > > } else if (!ret) {
> > > dep->flags |= DWC3_EP_END_TRANSFER_PENDING;
> > > --
> > > 2.25.1
> > >
> >
> > Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
>
> This patch breaks the build on my systems:
>
> CC [M] drivers/usb/dwc3/gadget.o
> drivers/usb/dwc3/gadget.c: In function ‘__dwc3_stop_active_transfer’:
> drivers/usb/dwc3/gadget.c:1702:22: error: unused variable ‘dwc’ [-Werror=unused-variable]
> 1702 | struct dwc3 *dwc = dep->dwc;
> | ^~~
> cc1: all warnings being treated as errors
>
> so I can't take it :(
Thanks Greg for reporting.
Hi Prashanth,
Can you resend v3 with the build fix. You can keep my Acked-by. Also,
please help test and catch these issues early to avoid turn-around time.
Thanks,
Thinh
prev parent reply other threads:[~2024-04-30 23:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 4:57 [PATCH v2] usb: dwc3: Wait unconditionally after issuing EndXfer command Prashanth K
2024-04-25 23:22 ` Thinh Nguyen
2024-04-30 16:06 ` Greg Kroah-Hartman
2024-04-30 22:59 ` Thinh Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240430225955.e7g53uycd35hcql3@synopsys.com \
--to=thinh.nguyen@synopsys.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=quic_prashk@quicinc.com \
--cc=quic_wcheng@quicinc.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).