Linux-Watchdog Archive mirror
 help / color / mirror / Atom feed
From: Claudiu <claudiu.beznea@tuxon.dev>
To: wim@linux-watchdog.org, linux@roeck-us.net, robh@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	p.zabel@pengutronix.de, geert+renesas@glider.be,
	magnus.damm@gmail.com, biju.das.jz@bp.renesas.com
Cc: linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	claudiu.beznea@tuxon.dev,
	Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Subject: [PATCH v3 1/8] watchdog: rzg2l_wdt: Select PM
Date: Fri,  2 Feb 2024 09:58:42 +0200	[thread overview]
Message-ID: <20240202075849.3422380-2-claudiu.beznea.uj@bp.renesas.com> (raw)
In-Reply-To: <20240202075849.3422380-1-claudiu.beznea.uj@bp.renesas.com>

From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>

The rzg2l_wdt watchdog driver cannot work w/o CONFIG_PM=y (e.g. the
clocks are enabled though pm_runtime_* specific APIs). To avoid building
a driver that doesn't work make it depend on CONFIG_PM.

Suggested-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
---

Changes in v3:
- make driver depend on PM; with that the "unmet direct dependency"
  Reported-by: kernel test robot <lkp@intel.com>
  was also fixed
- adapt commit message

Changes in v2:
- this patch is new

 drivers/watchdog/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
index 7d22051b15a2..c9abe8f307bb 100644
--- a/drivers/watchdog/Kconfig
+++ b/drivers/watchdog/Kconfig
@@ -910,7 +910,7 @@ config RENESAS_RZN1WDT
 
 config RENESAS_RZG2LWDT
 	tristate "Renesas RZ/G2L WDT Watchdog"
-	depends on ARCH_RENESAS || COMPILE_TEST
+	depends on (ARCH_RENESAS && PM) || COMPILE_TEST
 	select WATCHDOG_CORE
 	help
 	  This driver adds watchdog support for the integrated watchdogs in the
-- 
2.39.2


  reply	other threads:[~2024-02-02  7:59 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-02  7:58 [PATCH v3 0/8] watchdog: rzg2l_wdt: Add support for RZ/G3S Claudiu
2024-02-02  7:58 ` Claudiu [this message]
2024-02-02  8:03   ` [PATCH v3 1/8] watchdog: rzg2l_wdt: Select PM Biju Das
2024-02-02  8:14     ` Biju Das
2024-02-02  8:29       ` Biju Das
2024-02-05  6:12         ` claudiu beznea
2024-02-02  7:58 ` [PATCH v3 2/8] watchdog: rzg2l_wdt: Use pm_runtime_resume_and_get() Claudiu
2024-02-02  7:58 ` [PATCH v3 3/8] watchdog: rzg2l_wdt: Check return status of pm_runtime_put() Claudiu
2024-02-02  7:58 ` [PATCH v3 4/8] watchdog: rzg2l_wdt: Remove reset de-assert on probe/stop Claudiu
2024-02-02  7:58 ` [PATCH v3 5/8] watchdog: rzg2l_wdt: Remove comparison with zero Claudiu
2024-02-02  7:58 ` [PATCH v3 6/8] watchdog: rzg2l_wdt: Rely on the reset driver for doing proper reset Claudiu
2024-02-02  8:03   ` Philipp Zabel
2024-02-02  7:58 ` [PATCH v3 7/8] watchdog: rzg2l_wdt: Add suspend/resume support Claudiu
2024-02-02  7:58 ` [PATCH v3 8/8] dt-bindings: watchdog: renesas,wdt: Document RZ/G3S support Claudiu
2024-02-02 16:40   ` Conor Dooley
2024-02-05  6:14     ` claudiu beznea

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240202075849.3422380-2-claudiu.beznea.uj@bp.renesas.com \
    --to=claudiu.beznea@tuxon.dev \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=claudiu.beznea.uj@bp.renesas.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=magnus.damm@gmail.com \
    --cc=p.zabel@pengutronix.de \
    --cc=robh@kernel.org \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).