From: claudiu beznea <claudiu.beznea@tuxon.dev>
To: Biju Das <biju.das.jz@bp.renesas.com>,
"wim@linux-watchdog.org" <wim@linux-watchdog.org>,
"linux@roeck-us.net" <linux@roeck-us.net>,
"robh@kernel.org" <robh@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"geert+renesas@glider.be" <geert+renesas@glider.be>,
"magnus.damm@gmail.com" <magnus.damm@gmail.com>
Cc: "linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Subject: Re: [PATCH v3 1/8] watchdog: rzg2l_wdt: Select PM
Date: Mon, 5 Feb 2024 08:12:44 +0200 [thread overview]
Message-ID: <54cd6cdb-0dc5-497b-aada-23f53aff402d@tuxon.dev> (raw)
In-Reply-To: <TYCPR01MB11269FECF0067E0DC7D7CA0C986422@TYCPR01MB11269.jpnprd01.prod.outlook.com>
Hi, Biju,
On 02.02.2024 10:29, Biju Das wrote:
>>> -----Original Message-----
>>> From: Biju Das
>>> Sent: Friday, February 2, 2024 8:03 AM
>>> Subject: RE: [PATCH v3 1/8] watchdog: rzg2l_wdt: Select PM
>>>
>>> Hi Claudiu Beznea,
>>>
>>>> -----Original Message-----
>>>> From: Claudiu <claudiu.beznea@tuxon.dev>
>>>> Sent: Friday, February 2, 2024 7:59 AM
>>>> Subject: [PATCH v3 1/8] watchdog: rzg2l_wdt: Select PM
>>>>
>>>> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
>>>>
>>>> The rzg2l_wdt watchdog driver cannot work w/o CONFIG_PM=y (e.g. the
>>>> clocks are enabled though pm_runtime_* specific APIs). To avoid
>>>> building a driver that doesn't work make it depend on CONFIG_PM.
>>>>
>>>> Suggested-by: Guenter Roeck <linux@roeck-us.net>
>>>> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
>>>> ---
>>>>
>>>> Changes in v3:
>>>> - make driver depend on PM; with that the "unmet direct dependency"
>>>> Reported-by: kernel test robot <lkp@intel.com>
>>>> was also fixed
>>>> - adapt commit message
>>>>
>>>> Changes in v2:
>>>> - this patch is new
>>>>
>>>> drivers/watchdog/Kconfig | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
>>>> index 7d22051b15a2..c9abe8f307bb 100644
>>>> --- a/drivers/watchdog/Kconfig
>>>> +++ b/drivers/watchdog/Kconfig
>>>> @@ -910,7 +910,7 @@ config RENESAS_RZN1WDT
>>>>
>>>> config RENESAS_RZG2LWDT
>>>> tristate "Renesas RZ/G2L WDT Watchdog"
>>>> - depends on ARCH_RENESAS || COMPILE_TEST
>>>> + depends on (ARCH_RENESAS && PM) || COMPILE_TEST
>>>
>>> Since you are touching here, maybe ARCH_RZG2L?? like other RZ/G2L
>> drivers.
>>
>> Also RZ/V2M "ARCH_R9A09G011" as both these families using same driver.
Ok, I'll have another patch for that.
>
> Also commit header it is "Depend on" not "Select"?
Ok!
Thank you,
Claudiu Beznea
>
> Cheers,
> Biju
next prev parent reply other threads:[~2024-02-05 6:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-02 7:58 [PATCH v3 0/8] watchdog: rzg2l_wdt: Add support for RZ/G3S Claudiu
2024-02-02 7:58 ` [PATCH v3 1/8] watchdog: rzg2l_wdt: Select PM Claudiu
2024-02-02 8:03 ` Biju Das
2024-02-02 8:14 ` Biju Das
2024-02-02 8:29 ` Biju Das
2024-02-05 6:12 ` claudiu beznea [this message]
2024-02-02 7:58 ` [PATCH v3 2/8] watchdog: rzg2l_wdt: Use pm_runtime_resume_and_get() Claudiu
2024-02-02 7:58 ` [PATCH v3 3/8] watchdog: rzg2l_wdt: Check return status of pm_runtime_put() Claudiu
2024-02-02 7:58 ` [PATCH v3 4/8] watchdog: rzg2l_wdt: Remove reset de-assert on probe/stop Claudiu
2024-02-02 7:58 ` [PATCH v3 5/8] watchdog: rzg2l_wdt: Remove comparison with zero Claudiu
2024-02-02 7:58 ` [PATCH v3 6/8] watchdog: rzg2l_wdt: Rely on the reset driver for doing proper reset Claudiu
2024-02-02 8:03 ` Philipp Zabel
2024-02-02 7:58 ` [PATCH v3 7/8] watchdog: rzg2l_wdt: Add suspend/resume support Claudiu
2024-02-02 7:58 ` [PATCH v3 8/8] dt-bindings: watchdog: renesas,wdt: Document RZ/G3S support Claudiu
2024-02-02 16:40 ` Conor Dooley
2024-02-05 6:14 ` claudiu beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54cd6cdb-0dc5-497b-aada-23f53aff402d@tuxon.dev \
--to=claudiu.beznea@tuxon.dev \
--cc=biju.das.jz@bp.renesas.com \
--cc=claudiu.beznea.uj@bp.renesas.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=magnus.damm@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).