From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Daniel Golle <daniel@makrotopia.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 2/2] watchdog: mediatek: mt7988: add wdt support
Date: Fri, 10 Nov 2023 12:55:29 +0100 [thread overview]
Message-ID: <58b551f2-2d0b-4432-b1fd-edc690f13e4c@collabora.com> (raw)
In-Reply-To: <ddb5b6ca88165aa69f73fe2804eedd0231d8d9e7.1699576174.git.daniel@makrotopia.org>
Il 10/11/23 01:30, Daniel Golle ha scritto:
> Add support for watchdog and reset generator unit of the MediaTek
> MT7988 SoC.
>
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> ---
> drivers/watchdog/mtk_wdt.c | 56 +++++++++++++++++++++++++++++++++++++-
> 1 file changed, 55 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/mtk_wdt.c b/drivers/watchdog/mtk_wdt.c
> index b2330b16b497a..b98b8c29735aa 100644
> --- a/drivers/watchdog/mtk_wdt.c
> +++ b/drivers/watchdog/mtk_wdt.c
> @@ -12,6 +12,7 @@
> #include <dt-bindings/reset/mt2712-resets.h>
> #include <dt-bindings/reset/mediatek,mt6795-resets.h>
> #include <dt-bindings/reset/mt7986-resets.h>
> +#include <dt-bindings/reset/mediatek,mt7988-resets.h>
> #include <dt-bindings/reset/mt8183-resets.h>
> #include <dt-bindings/reset/mt8186-resets.h>
> #include <dt-bindings/reset/mt8188-resets.h>
> @@ -58,6 +59,8 @@
> #define WDT_SWSYSRST 0x18U
> #define WDT_SWSYS_RST_KEY 0x88000000
>
> +#define WDT_SWSYSRST_EN 0xfc
> +
> #define DRV_NAME "mtk-wdt"
> #define DRV_VERSION "1.0"
>
> @@ -71,44 +74,85 @@ struct mtk_wdt_dev {
> struct reset_controller_dev rcdev;
> bool disable_wdt_extrst;
> bool reset_by_toprgu;
> + bool has_swsysrst_en;
mtk_wdt_data is always a const and this has_swsysrst_en member is never supposed
to change during runtime.
At this point, just add a pointer to struct mtk_wdt_data in mtk_wdt_dev, then
instead of mtk_wdt->has_swsysrst_en you check mtk_wdt->pdata->has_swsysrst_en.
> };
>
> struct mtk_wdt_data {
> int toprgu_sw_rst_num;
> + bool has_swsysrst_en;
> };
>
> static const struct mtk_wdt_data mt2712_data = {
> .toprgu_sw_rst_num = MT2712_TOPRGU_SW_RST_NUM,
> + .has_swsysrst_en = false,
false == 0; 0 is init default; this assignment is useless.
> };
>
> static const struct mtk_wdt_data mt6795_data = {
> .toprgu_sw_rst_num = MT6795_TOPRGU_SW_RST_NUM,
> + .has_swsysrst_en = false,
> };
>
> static const struct mtk_wdt_data mt7986_data = {
> .toprgu_sw_rst_num = MT7986_TOPRGU_SW_RST_NUM,
> + .has_swsysrst_en = false,
> +};
> +
> +static const struct mtk_wdt_data mt7988_data = {
> + .toprgu_sw_rst_num = MT7988_TOPRGU_SW_RST_NUM,
> + .has_swsysrst_en = true,
> };
>
> static const struct mtk_wdt_data mt8183_data = {
> .toprgu_sw_rst_num = MT8183_TOPRGU_SW_RST_NUM,
> + .has_swsysrst_en = false,
> };
>
> static const struct mtk_wdt_data mt8186_data = {
> .toprgu_sw_rst_num = MT8186_TOPRGU_SW_RST_NUM,
> + .has_swsysrst_en = false,
> };
>
> static const struct mtk_wdt_data mt8188_data = {
> .toprgu_sw_rst_num = MT8188_TOPRGU_SW_RST_NUM,
> + .has_swsysrst_en = false,
> };
>
> static const struct mtk_wdt_data mt8192_data = {
> .toprgu_sw_rst_num = MT8192_TOPRGU_SW_RST_NUM,
> + .has_swsysrst_en = false,
> };
>
> static const struct mtk_wdt_data mt8195_data = {
> .toprgu_sw_rst_num = MT8195_TOPRGU_SW_RST_NUM,
> + .has_swsysrst_en = false,
> };
>
> +static int toprgu_reset_sw_enable(struct reset_controller_dev *rcdev,
> + unsigned long id, bool enable)
I would transfer this logic inside of toprgu_reset_update() (not literally!).
Doing so means that you would change this function to become
/**
* toprgu_reset_sw_en_unlocked - What this function does
* params
* warn about this *requiring* to be called in locked state
* check kerneldoc documentation :)))
*/
static void toprgu_reset_sw_en_unlocked(struct mtk_wdt_dev *mtk_wdt,
unsigned long id, bool assert)
{
u32 tmp;
tmp = readl....
if (...
blahblah
return 0;
}
and then call it in toprgu_reset_update(), before spin_unlock_irqrestore() like
{
stuff...
....
writel(.... SWSYSRST);
if (data->pdata->has_swsysrst_en)
toprgu_reset_sw_en_unlocked(data, id, assert);
spin_unlock_irqrestore(...)
return 0;
}
> +{
> + unsigned int tmp;
> + unsigned long flags;
> + struct mtk_wdt_dev *data =
> + container_of(rcdev, struct mtk_wdt_dev, rcdev);
> +
> + if (!data->has_swsysrst_en)
> + return 0;
> +
> + spin_lock_irqsave(&data->lock, flags);
> +
> + tmp = readl(data->wdt_base + WDT_SWSYSRST_EN);
> + if (enable)
> + tmp |= BIT(id);
> + else
> + tmp &= ~BIT(id);
> +
> + writel(tmp, data->wdt_base + WDT_SWSYSRST_EN);
> +
> + spin_unlock_irqrestore(&data->lock, flags);
> +
> + return 0;
> +}
> +
> static int toprgu_reset_update(struct reset_controller_dev *rcdev,
> unsigned long id, bool assert)
> {
> @@ -135,13 +179,20 @@ static int toprgu_reset_update(struct reset_controller_dev *rcdev,
> static int toprgu_reset_assert(struct reset_controller_dev *rcdev,
> unsigned long id)
> {
> + int ret;
> +
> + ret = toprgu_reset_sw_enable(rcdev, id, true);
> + if (ret)
> + return ret;
> +
> return toprgu_reset_update(rcdev, id, true);
...so you don't even touch this function...
> }
>
> static int toprgu_reset_deassert(struct reset_controller_dev *rcdev,
> unsigned long id)
> {
> - return toprgu_reset_update(rcdev, id, false);
> + toprgu_reset_update(rcdev, id, false);
> + return toprgu_reset_sw_enable(rcdev, id, false);
...nor that one.
> }
>
> static int toprgu_reset(struct reset_controller_dev *rcdev,
Cheers!
Angelo
next prev parent reply other threads:[~2023-11-10 18:27 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-10 0:30 [PATCH 1/2] dt-bindings: watchdog: mediatek,mtk-wdt: add MT7988 watchdog and toprgu Daniel Golle
2023-11-10 0:30 ` [PATCH 2/2] watchdog: mediatek: mt7988: add wdt support Daniel Golle
2023-11-10 5:24 ` Guenter Roeck
2023-11-10 11:55 ` AngeloGioacchino Del Regno [this message]
2023-11-10 15:13 ` Guenter Roeck
2023-11-10 8:09 ` [PATCH 1/2] dt-bindings: watchdog: mediatek,mtk-wdt: add MT7988 watchdog and toprgu Krzysztof Kozlowski
2023-11-10 15:20 ` Krzysztof Kozlowski
2023-11-10 20:00 ` Krzysztof Kozlowski
2023-11-10 20:45 ` Daniel Golle
2023-11-11 7:55 ` Krzysztof Kozlowski
2023-11-10 11:56 ` AngeloGioacchino Del Regno
2023-11-10 14:17 ` Daniel Golle
2023-11-10 14:20 ` Krzysztof Kozlowski
2023-11-10 14:40 ` Daniel Golle
2023-11-10 14:46 ` Krzysztof Kozlowski
2023-11-10 14:51 ` Daniel Golle
2023-11-10 15:07 ` Krzysztof Kozlowski
2023-11-10 15:12 ` Daniel Golle
2023-11-10 15:15 ` Krzysztof Kozlowski
2023-11-10 15:21 ` Krzysztof Kozlowski
2023-11-10 17:07 ` Daniel Golle
2023-11-10 19:58 ` Krzysztof Kozlowski
2023-11-10 20:18 ` Daniel Golle
2023-11-10 20:21 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58b551f2-2d0b-4432-b1fd-edc690f13e4c@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=daniel@makrotopia.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).