From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Daniel Golle <daniel@makrotopia.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 1/2] dt-bindings: watchdog: mediatek,mtk-wdt: add MT7988 watchdog and toprgu
Date: Fri, 10 Nov 2023 09:09:09 +0100 [thread overview]
Message-ID: <59629ec1-cc0c-4c5a-87cc-ea30d64ec191@linaro.org> (raw)
In-Reply-To: <6912f6f406bc45674020681184f3eeca2f2cb63f.1699576174.git.daniel@makrotopia.org>
On 10/11/2023 01:30, Daniel Golle wrote:
> Add binding description for mediatek,mt7988-wdt.
>
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> ---
...
> diff --git a/include/dt-bindings/reset/mediatek,mt7988-resets.h b/include/dt-bindings/reset/mediatek,mt7988-resets.h
> new file mode 100644
> index 0000000000000..fa7c937505e08
> --- /dev/null
> +++ b/include/dt-bindings/reset/mediatek,mt7988-resets.h
> @@ -0,0 +1,12 @@
> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
> +
> +/* TOPRGU resets */
> +#define MT7988_TOPRGU_SGMII0_GRST 1
> +#define MT7988_TOPRGU_SGMII1_GRST 2
> +#define MT7988_TOPRGU_XFI0_GRST 12
> +#define MT7988_TOPRGU_XFI1_GRST 13
> +#define MT7988_TOPRGU_XFI_PEXTP0_GRST 14
> +#define MT7988_TOPRGU_XFI_PEXTP1_GRST 15
> +#define MT7988_TOPRGU_XFI_PLL_GRST 16
IDs should start from 0 or 1 and increment by 1. If these are not IDs,
then you do not need them in the bindings.
Where is the driver change using these IDs?
> +
> +#define MT7988_TOPRGU_SW_RST_NUM 24
Why 24? I see 7. Why having it in the bindings in the first place.
It's quite likely I asked the same question about other bindings for
Mediatek. I will be asking every time till this is fixed.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-11-10 19:46 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-10 0:30 [PATCH 1/2] dt-bindings: watchdog: mediatek,mtk-wdt: add MT7988 watchdog and toprgu Daniel Golle
2023-11-10 0:30 ` [PATCH 2/2] watchdog: mediatek: mt7988: add wdt support Daniel Golle
2023-11-10 5:24 ` Guenter Roeck
2023-11-10 11:55 ` AngeloGioacchino Del Regno
2023-11-10 15:13 ` Guenter Roeck
2023-11-10 8:09 ` Krzysztof Kozlowski [this message]
2023-11-10 15:20 ` [PATCH 1/2] dt-bindings: watchdog: mediatek,mtk-wdt: add MT7988 watchdog and toprgu Krzysztof Kozlowski
2023-11-10 20:00 ` Krzysztof Kozlowski
2023-11-10 20:45 ` Daniel Golle
2023-11-11 7:55 ` Krzysztof Kozlowski
2023-11-10 11:56 ` AngeloGioacchino Del Regno
2023-11-10 14:17 ` Daniel Golle
2023-11-10 14:20 ` Krzysztof Kozlowski
2023-11-10 14:40 ` Daniel Golle
2023-11-10 14:46 ` Krzysztof Kozlowski
2023-11-10 14:51 ` Daniel Golle
2023-11-10 15:07 ` Krzysztof Kozlowski
2023-11-10 15:12 ` Daniel Golle
2023-11-10 15:15 ` Krzysztof Kozlowski
2023-11-10 15:21 ` Krzysztof Kozlowski
2023-11-10 17:07 ` Daniel Golle
2023-11-10 19:58 ` Krzysztof Kozlowski
2023-11-10 20:18 ` Daniel Golle
2023-11-10 20:21 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59629ec1-cc0c-4c5a-87cc-ea30d64ec191@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=daniel@makrotopia.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).