From: Biju Das <biju.das.jz@bp.renesas.com>
To: Claudiu.Beznea <claudiu.beznea@tuxon.dev>,
"wim@linux-watchdog.org" <wim@linux-watchdog.org>,
"linux@roeck-us.net" <linux@roeck-us.net>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"geert+renesas@glider.be" <geert+renesas@glider.be>,
"magnus.damm@gmail.com" <magnus.damm@gmail.com>,
"mturquette@baylibre.com" <mturquette@baylibre.com>,
"sboyd@kernel.org" <sboyd@kernel.org>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>
Cc: "linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Subject: RE: [PATCH v2 04/11] watchdog: rzg2l_wdt: Check return status of pm_runtime_put()
Date: Wed, 31 Jan 2024 10:41:43 +0000 [thread overview]
Message-ID: <TYCPR01MB11269BFC2DB457049A2B8C0C8867C2@TYCPR01MB11269.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <ddc0b42c-bf88-4c0d-b938-8bd7ff7b329a@tuxon.dev>
Hi Claudiu,
> -----Original Message-----
> From: claudiu beznea <claudiu.beznea@tuxon.dev>
> Sent: Wednesday, January 31, 2024 10:36 AM
> Subject: Re: [PATCH v2 04/11] watchdog: rzg2l_wdt: Check return status of
> pm_runtime_put()
>
> Hi, Biju,
>
> On 31.01.2024 12:32, Biju Das wrote:
> > Hi Claudiu,
> >
> > Thanks for the feedback.
> >
> >> -----Original Message-----
> >> From: Claudiu <claudiu.beznea@tuxon.dev>
> >> Sent: Wednesday, January 31, 2024 10:20 AM
> >> Subject: [PATCH v2 04/11] watchdog: rzg2l_wdt: Check return status of
> >> pm_runtime_put()
> >>
> >> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
> >>
> >> pm_runtime_put() may return an error code. Check its return status.
> >>
> >> Along with it the rzg2l_wdt_set_timeout() function was updated to
> >> propagate the result of rzg2l_wdt_stop() to its caller.
> >>
> >> Fixes: 2cbc5cd0b55f ("watchdog: Add Watchdog Timer driver for
> >> RZ/G2L")
> >> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
> >> ---
> >>
> >> Changes in v2:
> >> - propagate the return code of rzg2l_wdt_stop() to it's callers
> >>
> >> drivers/watchdog/rzg2l_wdt.c | 11 +++++++++--
> >> 1 file changed, 9 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/watchdog/rzg2l_wdt.c
> >> b/drivers/watchdog/rzg2l_wdt.c index d87d4f50180c..7bce093316c4
> >> 100644
> >> --- a/drivers/watchdog/rzg2l_wdt.c
> >> +++ b/drivers/watchdog/rzg2l_wdt.c
> >> @@ -144,9 +144,13 @@ static int rzg2l_wdt_start(struct
> >> watchdog_device
> >> *wdev) static int rzg2l_wdt_stop(struct watchdog_device *wdev) {
> >> struct rzg2l_wdt_priv *priv = watchdog_get_drvdata(wdev);
> >> + int ret;
> >>
> >> rzg2l_wdt_reset(priv);
> >> - pm_runtime_put(wdev->parent);
> >> +
> >> + ret = pm_runtime_put(wdev->parent);
> >> + if (ret < 0)
> >> + return ret;
> >
> > Do we need to check the return code? So far we didn't hit this
> condition.
> > If you are planning to do it, then just
> >
> > return pm_runtime_put(wdev->parent);
>
> pm_runtime_put() may return 1 if the device is suspended (which is not
> considered error) as explained here:
Oops, I missed that discussion. Out of curiosity,
What watchdog framework/consumer is going to do with a
Non-error return value of 1?
Cheers,
Biju
next prev parent reply other threads:[~2024-01-31 10:41 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 10:20 [PATCH v2 00/11] watchdog: rzg2l_wdt: Add support for RZ/G3S Claudiu
2024-01-31 10:20 ` [PATCH v2 01/11] clk: renesas: r9a08g045: Add clock and reset support for watchdog Claudiu
2024-01-31 10:20 ` [PATCH v2 02/11] watchdog: rzg2l_wdt: Select PM Claudiu
2024-02-01 8:52 ` Geert Uytterhoeven
2024-02-01 13:36 ` Guenter Roeck
2024-02-01 21:05 ` kernel test robot
2024-01-31 10:20 ` [PATCH v2 03/11] watchdog: rzg2l_wdt: Use pm_runtime_resume_and_get() Claudiu
2024-01-31 10:20 ` [PATCH v2 04/11] watchdog: rzg2l_wdt: Check return status of pm_runtime_put() Claudiu
2024-01-31 10:32 ` Biju Das
2024-01-31 10:35 ` claudiu beznea
2024-01-31 10:41 ` Biju Das [this message]
2024-01-31 11:00 ` claudiu beznea
2024-01-31 13:16 ` Guenter Roeck
2024-02-01 6:11 ` claudiu beznea
2024-01-31 13:14 ` Guenter Roeck
2024-01-31 13:38 ` Biju Das
2024-01-31 10:20 ` [PATCH v2 05/11] watchdog: rzg2l_wdt: Remove reset de-assert on probe/stop Claudiu
2024-01-31 10:20 ` [PATCH v2 06/11] watchdog: rzg2l_wdt: Remove comparison with zero Claudiu
2024-01-31 10:20 ` [PATCH v2 07/11] watchdog: rzg2l_wdt: Rely on the reset driver for doing proper reset Claudiu
2024-01-31 10:20 ` [PATCH v2 08/11] watchdog: rzg2l_wdt: Add suspend/resume support Claudiu
2024-01-31 10:20 ` [PATCH v2 09/11] dt-bindings: watchdog: renesas,wdt: Document RZ/G3S support Claudiu
2024-01-31 10:20 ` [PATCH v2 10/11] arm64: dts: renesas: r9a08g045: Add watchdog node Claudiu
2024-01-31 10:20 ` [PATCH v2 11/11] arm64: dts: renesas: rzg3s-smarc-som: Enable the watchdog interface Claudiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TYCPR01MB11269BFC2DB457049A2B8C0C8867C2@TYCPR01MB11269.jpnprd01.prod.outlook.com \
--to=biju.das.jz@bp.renesas.com \
--cc=claudiu.beznea.uj@bp.renesas.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=magnus.damm@gmail.com \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).