From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: Pradeep Kumar Chitrapu <quic_pradeepc@quicinc.com>,
<ath12k@lists.infradead.org>
Cc: <linux-wireless@vger.kernel.org>, Muna Sinada <quic_msinada@quicinc.com>
Subject: Re: [PATCH v3 02/10] wifi: ath12k: push HE MU-MIMO params from hostapd to hardware
Date: Thu, 25 Apr 2024 15:40:04 -0700 [thread overview]
Message-ID: <034950cb-cf04-443f-a13c-b7d7a47ff0d7@quicinc.com> (raw)
In-Reply-To: <20240424201959.935-3-quic_pradeepc@quicinc.com>
On 4/24/2024 1:19 PM, Pradeep Kumar Chitrapu wrote:
> Currently, only the HE IE in management frames is updated with
> respect to MU-MIMO configurations, but this change is not
> reflected in the hardware. Add support to propagate MU-MIMO
> configurations to the hardware as well.
>
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
>
> Co-developed-by: Muna Sinada <quic_msinada@quicinc.com>
> Signed-off-by: Muna Sinada <quic_msinada@quicinc.com>
> Signed-off-by: Pradeep Kumar Chitrapu <quic_pradeepc@quicinc.com>
> ---
> drivers/net/wireless/ath/ath12k/mac.c | 214 +++++++++++++++++---------
> drivers/net/wireless/ath/ath12k/mac.h | 15 ++
> drivers/net/wireless/ath/ath12k/wmi.h | 28 +---
> 3 files changed, 155 insertions(+), 102 deletions(-)
>
[...]
> static void ath12k_bss_assoc(struct ath12k *ar,
> struct ath12k_vif *arvif,
> struct ieee80211_bss_conf *bss_conf)
drivers/net/wireless/ath/ath12k/mac.c:2816:13: warning: context imbalance in 'ath12k_bss_assoc' - wrong count at exit
see reason below
> {
> struct ieee80211_vif *vif = arvif->vif;
> struct ath12k_wmi_peer_assoc_arg peer_arg;
> + struct ieee80211_sta_he_cap he_cap;
> struct ieee80211_sta *ap_sta;
> struct ath12k_peer *peer;
> bool is_auth = false;
> + u32 hemode = 0;
> int ret;
>
> lockdep_assert_held(&ar->conf_mutex);
> @@ -2556,8 +2660,28 @@ static void ath12k_bss_assoc(struct ath12k *ar,
>
> ath12k_peer_assoc_prepare(ar, vif, ap_sta, &peer_arg, false);
>
> + /* he_cap here is updated at assoc success for sta mode only */
> + he_cap = ap_sta->deflink.he_cap;
> +
> + /* ap_sta->deflink.he_cap must be protected by rcu_read_lock */
> + ret = ath12k_mac_vif_recalc_sta_he_txbf(ar, vif, &he_cap, &hemode);
> + if (ret) {
> + ath12k_warn(ar->ab, "failed to recalc he txbf for vdev %i on bss %pM: %d\n",
> + arvif->vdev_id, bss_conf->bssid, ret);
> + return;
bad return within rcu_read_lock() critical section
> + }
> +
> rcu_read_unlock();
>
next prev parent reply other threads:[~2024-04-25 22:40 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 20:19 [PATCH v3 00/10] wifi: ath12k: add MU-MIMO and 160 MHz bandwidth support Pradeep Kumar Chitrapu
2024-04-24 20:19 ` [PATCH v3 01/10] wifi: mac80211: Add EHT UL MU-MIMO flag in ieee80211_bss_conf Pradeep Kumar Chitrapu
2024-04-24 20:19 ` [PATCH v3 02/10] wifi: ath12k: push HE MU-MIMO params from hostapd to hardware Pradeep Kumar Chitrapu
2024-04-25 22:40 ` Jeff Johnson [this message]
2024-04-24 20:19 ` [PATCH v3 03/10] wifi: ath12k: push EHT " Pradeep Kumar Chitrapu
2024-04-25 22:46 ` Jeff Johnson
2024-04-24 20:19 ` [PATCH v3 04/10] wifi: ath12k: move HE MCS mapper to a separate function Pradeep Kumar Chitrapu
2024-04-24 20:19 ` [PATCH v3 05/10] wifi: ath12k: generate rx and tx mcs maps for supported HE mcs Pradeep Kumar Chitrapu
2024-04-24 20:19 ` [PATCH v3 06/10] wifi: ath12k: fix TX and RX MCS rate configurations in HE mode Pradeep Kumar Chitrapu
2024-04-24 20:19 ` [PATCH v3 07/10] wifi: ath12k: add support for setting fixed HE rate/GI/LTF Pradeep Kumar Chitrapu
2024-04-25 22:32 ` Jeff Johnson
2024-04-25 23:37 ` Jeff Johnson
2024-04-26 7:31 ` Kalle Valo
2024-04-26 23:42 ` Pradeep Kumar Chitrapu
2024-04-29 12:08 ` Kalle Valo
2024-04-30 1:41 ` Pradeep Kumar Chitrapu
2024-04-30 6:42 ` Kalle Valo
2024-04-24 20:19 ` [PATCH v3 08/10] wifi: ath12k: clean up 80P80 support Pradeep Kumar Chitrapu
2024-04-24 20:19 ` [PATCH v3 09/10] wifi: ath12k: add support for 160 MHz bandwidth Pradeep Kumar Chitrapu
2024-04-24 20:19 ` [PATCH v3 10/10] wifi: ath12k: add extended NSS bandwidth support for 160 MHz Pradeep Kumar Chitrapu
2024-04-25 6:48 ` [PATCH v3 00/10] wifi: ath12k: add MU-MIMO and 160 MHz bandwidth support Kalle Valo
2024-04-25 22:48 ` Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=034950cb-cf04-443f-a13c-b7d7a47ff0d7@quicinc.com \
--to=quic_jjohnson@quicinc.com \
--cc=ath12k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_msinada@quicinc.com \
--cc=quic_pradeepc@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).