From: Pradeep Kumar Chitrapu <quic_pradeepc@quicinc.com>
To: Kalle Valo <kvalo@kernel.org>
Cc: Jeff Johnson <quic_jjohnson@quicinc.com>,
<ath12k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
Muna Sinada <quic_msinada@quicinc.com>
Subject: Re: [PATCH v3 07/10] wifi: ath12k: add support for setting fixed HE rate/GI/LTF
Date: Mon, 29 Apr 2024 18:41:37 -0700 [thread overview]
Message-ID: <51073e2c-2138-4957-a78c-2708c7742451@quicinc.com> (raw)
In-Reply-To: <87sez4fk1o.fsf@kernel.org>
On 4/29/2024 5:08 AM, Kalle Valo wrote:
> Pradeep Kumar Chitrapu <quic_pradeepc@quicinc.com> writes:
>
>> On 4/26/2024 12:31 AM, Kalle Valo wrote:
>>> Jeff Johnson <quic_jjohnson@quicinc.com> writes:
>>>
>>>> On 4/24/2024 1:19 PM, Pradeep Kumar Chitrapu wrote:
>>>>> Add support to set fixed HE rate/GI/LTF values using nl80211.
>>>>> Reuse parts of the existing code path already used for HT/VHT
>>>>> to implement the new helpers symmetrically, similar to how
>>>>> HT/VHT is handled.
>>>>>
>>>>> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
>>>>>
>>>>> Co-developed-by: Muna Sinada <quic_msinada@quicinc.com>
>>>>> Signed-off-by: Muna Sinada <quic_msinada@quicinc.com>
>>>>> Signed-off-by: Pradeep Kumar Chitrapu <quic_pradeepc@quicinc.com>
>>>>> ---
>>>>
>>>> [...]
>>>>
>>>>> @@ -7753,7 +8034,20 @@ ath12k_mac_bitrate_mask_get_single_nss(struct ath12k *ar,
>>>>> return false;
>>>>> }
>>>>> - if (ht_nss_mask != vht_nss_mask)
>>>>> + he_mcs_map = le16_to_cpu(ath12k_mac_get_tx_mcs_map(&sband->iftype_data->he_cap));
>>>>
>>>> drivers/net/wireless/ath/ath12k/mac.c:8041:22: warning: incorrect type in argument 1 (different address spaces)
>>>> drivers/net/wireless/ath/ath12k/mac.c:8041:22: expected struct ieee80211_sta_he_cap const *he_cap
>>>> drivers/net/wireless/ath/ath12k/mac.c:8041:22: got struct ieee80211_sta_he_cap const [noderef] __iftype_data *
>>> ALWAYS run ath12k-check, we wrote the tool for a reason. Skipping
>>> these
>>> tests is disrespect for maintainers' time and a great way to get your
>>> patches to the bottom of the queue.
>>>
>> Hi Kalle
>>
>> I did run ath12k-check but I don't see these errors. Trying to see if
>> this is due to version differences. will update further once I have
>> more information on this.
>>
>> This is version I ran:
>> qca-swiss-army-knife/tools/scripts/ath12k/ath12k-check --version
>> ath12k-check (md5sum cb8a85242f2ec7343f6f94af9fa5ebb2)
>>
>> python: 3.6.9 (default, Mar 10 2023, 16:46:00)
>> [GCC 8.4.0]
>> host gcc: gcc (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0
>> config cc: gcc (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0
>> sparse: v0.6.4
>> checkpatch.pl: Version: 0.32 (md5sum 12ea394e9bf27280f30a684ff937cc57)
>> gtags: gtags (GNU GLOBAL) 6.6.2
>
> Your sparse is too old, you need to get the latest from git:
>
> https://docs.kernel.org/dev-tools/sparse.html#getting-sparse
Thanks Kalle and Jeff for sharing the tool versions required..
I am able to see the errors reported now..
will fix and respin the series..
ath12k-check (md5sum cb8a85242f2ec7343f6f94af9fa5ebb2)
python: 3.6.9 (default, Mar 10 2023, 16:46:00)
[GCC 8.4.0]
host gcc: gcc (GCC) 13.2.0
config cc: gcc (GCC) 13.2.0
sparse: v0.6.4-66-g0196afe16a50
checkpatch.pl: Version: 0.32 (md5sum 12ea394e9bf27280f30a684ff937cc57)
gtags: gtags (GNU GLOBAL) 6.6.2
Thanks
Pradeep
>
> Also your GCC is really old, I strongly recommend to use GCC 13.2. You
> can get it here:
>
> https://mirrors.edge.kernel.org/pub/tools/crosstool/
>
> Why on earth are you using Ubuntu 18.04? It's end of life was a year
> ago.
Will get update ubuntu in few days.
>
> And please also update ath12k-check. This is what I have:
>
> $ ath12k-check --version
> ath12k-check (md5sum c5567fc8aaede613275e8cafea6ed7cd)
>
> python: 3.11.2 (main, Mar 13 2023, 12:18:29) [GCC 12.2.0]
> host gcc: gcc (Debian 12.2.0-14) 12.2.0
> config cc: x86_64-linux-gcc (GCC) 13.2.0
> sparse: v0.6.4-39-gce1a6720f69e
> checkpatch.pl: Version: 0.32 (md5sum 77c655474ed7622c0077caf2f0d7c440)
> gtags: gtags (Global) 6.6.9
>
>> I see some notes like below this in all files:
>> drivers/net/wireless/ath/ath12k/mac.c: note: in included file (through
>> include/linux/bitops.h, include/linux/kernel.h,
>> include/net/mac80211.h):
>> drivers/net/wireless/ath/ath12k/mac.c: note: in included file (through
>> include/linux/bitops.h, include/linux/kernel.h,
>> include/net/mac80211.h):
>
> Jeff and me are extra careful that there are no warnings in ath12k, in
> fact in wireless-next the whole wireless subsystem has no sparse
> warnings. So if you ever see warnings please report them to maintainers
> ASAP.
>
next prev parent reply other threads:[~2024-04-30 1:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 20:19 [PATCH v3 00/10] wifi: ath12k: add MU-MIMO and 160 MHz bandwidth support Pradeep Kumar Chitrapu
2024-04-24 20:19 ` [PATCH v3 01/10] wifi: mac80211: Add EHT UL MU-MIMO flag in ieee80211_bss_conf Pradeep Kumar Chitrapu
2024-04-24 20:19 ` [PATCH v3 02/10] wifi: ath12k: push HE MU-MIMO params from hostapd to hardware Pradeep Kumar Chitrapu
2024-04-25 22:40 ` Jeff Johnson
2024-04-24 20:19 ` [PATCH v3 03/10] wifi: ath12k: push EHT " Pradeep Kumar Chitrapu
2024-04-25 22:46 ` Jeff Johnson
2024-04-24 20:19 ` [PATCH v3 04/10] wifi: ath12k: move HE MCS mapper to a separate function Pradeep Kumar Chitrapu
2024-04-24 20:19 ` [PATCH v3 05/10] wifi: ath12k: generate rx and tx mcs maps for supported HE mcs Pradeep Kumar Chitrapu
2024-04-24 20:19 ` [PATCH v3 06/10] wifi: ath12k: fix TX and RX MCS rate configurations in HE mode Pradeep Kumar Chitrapu
2024-04-24 20:19 ` [PATCH v3 07/10] wifi: ath12k: add support for setting fixed HE rate/GI/LTF Pradeep Kumar Chitrapu
2024-04-25 22:32 ` Jeff Johnson
2024-04-25 23:37 ` Jeff Johnson
2024-04-26 7:31 ` Kalle Valo
2024-04-26 23:42 ` Pradeep Kumar Chitrapu
2024-04-29 12:08 ` Kalle Valo
2024-04-30 1:41 ` Pradeep Kumar Chitrapu [this message]
2024-04-30 6:42 ` Kalle Valo
2024-04-24 20:19 ` [PATCH v3 08/10] wifi: ath12k: clean up 80P80 support Pradeep Kumar Chitrapu
2024-04-24 20:19 ` [PATCH v3 09/10] wifi: ath12k: add support for 160 MHz bandwidth Pradeep Kumar Chitrapu
2024-04-24 20:19 ` [PATCH v3 10/10] wifi: ath12k: add extended NSS bandwidth support for 160 MHz Pradeep Kumar Chitrapu
2024-04-25 6:48 ` [PATCH v3 00/10] wifi: ath12k: add MU-MIMO and 160 MHz bandwidth support Kalle Valo
2024-04-25 22:48 ` Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51073e2c-2138-4957-a78c-2708c7742451@quicinc.com \
--to=quic_pradeepc@quicinc.com \
--cc=ath12k@lists.infradead.org \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_jjohnson@quicinc.com \
--cc=quic_msinada@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).