From: kangyang <quic_kangyang@quicinc.com>
To: <ath12k@lists.infradead.org>
Cc: <linux-wireless@vger.kernel.org>, <quic_kangyang@quicinc.com>
Subject: [PATCH 3/5] wifi: ath12k: avoid duplicated vdev down
Date: Mon, 29 Apr 2024 16:15:23 +0800 [thread overview]
Message-ID: <20240429081525.983-4-quic_kangyang@quicinc.com> (raw)
In-Reply-To: <20240429081525.983-1-quic_kangyang@quicinc.com>
From: Kang Yang <quic_kangyang@quicinc.com>
ath12k_mac_op_unassign_vif_chanctx() will do vdev down in function
ath12k_mac_monitor_stop(). So no need to do vdev down again.
remove the duplicated one.
Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3
Signed-off-by: Kang Yang <quic_kangyang@quicinc.com>
---
drivers/net/wireless/ath/ath12k/mac.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/wireless/ath/ath12k/mac.c b/drivers/net/wireless/ath/ath12k/mac.c
index 4f553f2a7165..9a2823bcf8fc 100644
--- a/drivers/net/wireless/ath/ath12k/mac.c
+++ b/drivers/net/wireless/ath/ath12k/mac.c
@@ -7379,10 +7379,6 @@ ath12k_mac_op_unassign_vif_chanctx(struct ieee80211_hw *hw,
}
arvif->is_started = false;
- if (ab->hw_params->vdev_start_delay &&
- arvif->vdev_type == WMI_VDEV_TYPE_MONITOR)
- ath12k_wmi_vdev_down(ar, arvif->vdev_id);
-
if (arvif->vdev_type != WMI_VDEV_TYPE_MONITOR &&
ar->num_started_vdevs == 1 && ar->monitor_vdev_created)
ath12k_mac_monitor_stop(ar);
--
2.34.1
next prev parent reply other threads:[~2024-04-29 8:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 8:15 [PATCH 0/5] prepare work for monitor mode on WCN7850 kangyang
2024-04-29 8:15 ` [PATCH 1/5] wifi: ath12k: remove unused variable monitor_flags kangyang
2024-04-30 1:49 ` Jeff Johnson
2024-05-07 10:18 ` Kalle Valo
2024-04-29 8:15 ` [PATCH 2/5] wifi: ath12k: avoid duplicated vdev stop kangyang
2024-04-30 1:51 ` Jeff Johnson
2024-04-29 8:15 ` kangyang [this message]
2024-04-30 1:52 ` [PATCH 3/5] wifi: ath12k: avoid duplicated vdev down Jeff Johnson
2024-04-29 8:15 ` [PATCH 4/5] wifi: ath12k: remove redundant peer delete kangyang
2024-04-30 1:53 ` Jeff Johnson
2024-05-07 10:20 ` Kalle Valo
2024-05-07 11:20 ` Kang Yang
2024-04-29 8:15 ` [PATCH 5/5] wifi: ath12k: remove invalid peer create logic kangyang
2024-04-30 1:55 ` Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240429081525.983-4-quic_kangyang@quicinc.com \
--to=quic_kangyang@quicinc.com \
--cc=ath12k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).