From: Jeff Johnson <quic_jjohnson@quicinc.com>
To: kangyang <quic_kangyang@quicinc.com>, <ath12k@lists.infradead.org>
Cc: <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 2/5] wifi: ath12k: avoid duplicated vdev stop
Date: Mon, 29 Apr 2024 18:51:27 -0700 [thread overview]
Message-ID: <e32ac83d-02d0-45e1-acac-7a466cdf41e3@quicinc.com> (raw)
In-Reply-To: <20240429081525.983-3-quic_kangyang@quicinc.com>
On 4/29/2024 1:15 AM, kangyang wrote:
> From: Kang Yang <quic_kangyang@quicinc.com>
>
> ath12k_mac_op_unassign_vif_chanctx() will do vdev stop in
> ath12k_mac_monitor_stop(). This ath12k_mac_vdev_stop() will do vdev stop
s/This/Then/?
Kalle can fix this in the pending branch
> again, then might trigger firmware crash.
>
> So add judgement to avoid duplicated vdev stop.
>
> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3
>
> Fixes: c9e4e41e71ff ("wifi: ath12k: move peer delete after vdev stop of station for WCN7850")
> Signed-off-by: Kang Yang <quic_kangyang@quicinc.com>
Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
next prev parent reply other threads:[~2024-04-30 1:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 8:15 [PATCH 0/5] prepare work for monitor mode on WCN7850 kangyang
2024-04-29 8:15 ` [PATCH 1/5] wifi: ath12k: remove unused variable monitor_flags kangyang
2024-04-30 1:49 ` Jeff Johnson
2024-05-07 10:18 ` Kalle Valo
2024-04-29 8:15 ` [PATCH 2/5] wifi: ath12k: avoid duplicated vdev stop kangyang
2024-04-30 1:51 ` Jeff Johnson [this message]
2024-04-29 8:15 ` [PATCH 3/5] wifi: ath12k: avoid duplicated vdev down kangyang
2024-04-30 1:52 ` Jeff Johnson
2024-04-29 8:15 ` [PATCH 4/5] wifi: ath12k: remove redundant peer delete kangyang
2024-04-30 1:53 ` Jeff Johnson
2024-05-07 10:20 ` Kalle Valo
2024-05-07 11:20 ` Kang Yang
2024-04-29 8:15 ` [PATCH 5/5] wifi: ath12k: remove invalid peer create logic kangyang
2024-04-30 1:55 ` Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e32ac83d-02d0-45e1-acac-7a466cdf41e3@quicinc.com \
--to=quic_jjohnson@quicinc.com \
--cc=ath12k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_kangyang@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).