From: Aloka Dixit <quic_alokad@quicinc.com>
To: "Johannes Berg" <johannes@sipsolutions.net>,
"Allen Ye (葉芷勳)" <Allen.Ye@mediatek.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"lorenzo@kernel.org" <lorenzo@kernel.org>
Cc: "lorenzo.bianconi@redhat.com" <lorenzo.bianconi@redhat.com>,
"nbd@nbd.name" <nbd@nbd.name>,
"Evelyn Tsai (蔡珊鈺)" <Evelyn.Tsai@mediatek.com>,
"Money Wang (王信安)" <Money.Wang@mediatek.com>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH v2] wifi: mac80211: Update bssid indicator with real BSS numbers
Date: Thu, 2 May 2024 09:45:05 -0700 [thread overview]
Message-ID: <a840697a-3f58-1c0f-2ca3-66b04686c529@quicinc.com> (raw)
In-Reply-To: <e9c1c8fb20c39ed158f11a6152dc594de6073726.camel@sipsolutions.net>
On 4/23/2024 4:28 AM, Johannes Berg wrote:
> On Tue, 2024-04-23 at 13:21 +0200, Johannes Berg wrote:
>>
>> Anyway, I think I agree, but can you please add some validation of this
>> to cfg80211 as a first patch
>
> I guess I should say what kind of validation? I think it'd make sense to
> ensure that the elements even exist/are long enough (currently there's
> no validation in nl80211_parse_mbssid_elems at all!!), perhaps call
> validate_ie_attr() there as well.
>
> Feels like something should also ensure that not only is
>
> config->index < wiphy->mbssid_max_interfaces
>
> but also actually < 2^max_bssid_indicator?
>
> johannes
>
I agree with the validation concerns.
But the actual logic in this patch is valid, although considering we
have had this code for so many years now, feels like no driver/target
actually needs this field yet even though it is used :-)
next prev parent reply other threads:[~2024-05-02 16:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-08 6:38 [PATCH v2] wifi: mac80211: Update bssid indicator with real BSS numbers Allen Ye
2023-12-14 12:29 ` Johannes Berg
2023-12-27 9:38 ` Allen Ye (葉芷勳)
2024-04-23 11:21 ` Johannes Berg
2024-04-23 11:28 ` Johannes Berg
2024-05-02 16:45 ` Aloka Dixit [this message]
2024-04-23 19:12 ` Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a840697a-3f58-1c0f-2ca3-66b04686c529@quicinc.com \
--to=quic_alokad@quicinc.com \
--cc=Allen.Ye@mediatek.com \
--cc=Evelyn.Tsai@mediatek.com \
--cc=Money.Wang@mediatek.com \
--cc=johannes@sipsolutions.net \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=lorenzo@kernel.org \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).