From: Ping-Ke Shih <pkshih@realtek.com>
To: Bitterblue Smith <rtl8821cerfe2@gmail.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: Jes Sorensen <Jes.Sorensen@gmail.com>, Ping-Ke Shih <pkshih@realtek.com>
Subject: Re: [PATCH v2] wifi: rtl8xxxu: Add LED control code for RTL8723BU
Date: Fri, 19 Apr 2024 10:03:56 +0800 [thread overview]
Message-ID: <e4a3c968-9127-45c4-9187-b573d5f349d8@RTEXMBS04.realtek.com.tw> (raw)
In-Reply-To: <c0e93225-4672-48ac-9bdf-9d0fad00116e@gmail.com>
Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:
> Software control (on/off) and hardware control (automatic blinking)
> tested with EDUP EP-N8568.
>
> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
Checkpatch warns:
WARNING: Missing a blank line after declarations
#28: FILE: drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723b.c:1711:
+ u8 ledcfg = rtl8xxxu_read8(priv, REG_LEDCFG2);
+ ledcfg &= LEDCFG2_DPDT_SELECT;
WARNING: braces {} are not necessary for any arm of this statement
#30: FILE: drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8723b.c:1713:
+ if (brightness == LED_OFF) {
[...]
+ } else if (brightness == LED_ON) {
[...]
+ } else if (brightness == RTL8XXXU_HW_LED_CONTROL) {
[...]
Set patchset state to Changes Requested
[v2] wifi: rtl8xxxu: Add LED control code for RTL8723BU
---
https://github.com/pkshih/rtw.git
prev parent reply other threads:[~2024-04-19 2:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 10:48 [PATCH v2] wifi: rtl8xxxu: Add LED control code for RTL8723BU Bitterblue Smith
2024-04-19 2:03 ` Ping-Ke Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4a3c968-9127-45c4-9187-b573d5f349d8@RTEXMBS04.realtek.com.tw \
--to=pkshih@realtek.com \
--cc=Jes.Sorensen@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rtl8821cerfe2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).