From: "Sricharan" <sricharan@codeaurora.org>
To: "'Wolfram Sang'" <wsa@the-dreams.de>
Cc: <devicetree@vger.kernel.org>, <architt@codeaurora.org>,
<linux-arm-msm@vger.kernel.org>, <ntelkar@codeaurora.org>,
<agross@codeaurora.org>, <linux-kernel@vger.kernel.org>,
<dmaengine@vger.kernel.org>, <linux-i2c@vger.kernel.org>,
<iivanov@mm-sol.com>, <galak@codeaurora.org>,
<andy.gross@linaro.org>, <linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH V7 0/6] i2c: qup: Add support for v2 tags and bam dma
Date: Thu, 28 Jan 2016 10:57:51 +0530 [thread overview]
Message-ID: <001d01d1598c$a6dc1630$f4944290$@codeaurora.org> (raw)
In-Reply-To: <20160124113318.GB1775@katana>
Hi Wolfram,
> -----Original Message-----
> From: linux-arm-kernel [mailto:linux-arm-kernel-
> bounces@lists.infradead.org] On Behalf Of Wolfram Sang
> Sent: Sunday, January 24, 2016 5:03 PM
> To: Sricharan
> Cc: devicetree@vger.kernel.org; architt@codeaurora.org; linux-arm-
> msm@vger.kernel.org; ntelkar@codeaurora.org; agross@codeaurora.org;
> linux-kernel@vger.kernel.org; dmaengine@vger.kernel.org; linux-
> i2c@vger.kernel.org; iivanov@mm-sol.com; galak@codeaurora.org;
> andy.gross@linaro.org; linux-arm-kernel@lists.infradead.org
> Subject: Re: [PATCH V7 0/6] i2c: qup: Add support for v2 tags and bam dma
>
> > > Sricharan R (6):
> > > i2c: qup: Change qup_wait_writeready function to use for all
timeouts
> > > i2c: qup: Add V2 tags support
> > > i2c: qup: Transfer each i2c_msg in i2c_msgs without a stop bit
> > > i2c: qup: Add bam dma capabilities
> > > dts: msm8974: Add blsp2_bam dma node
> > > dts: msm8974: Add dma channels for blsp2_i2c1 node
> > >
> > Wolfram, Does the first 4 patches looks good to be picked up ?
>
> Except for patch 3 (I replied seperately), the rest looks okay to me. I
> wondered a little if it would make sense to make a new driver for v2 +
DMA,
> because the additions were quite massive. But I'll leave it up to you if
there is
> enough shared code between the two versions, so that a single driver will
be
> better.
Hmm, addition of V2 reused code, more than 50% addition of new loc in
this series, lot of it from DMA,
but at this point it feels ok to have it in a single driver.
Regards,
Sricharan
prev parent reply other threads:[~2016-01-28 5:28 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-19 10:02 [PATCH V7 0/6] i2c: qup: Add support for v2 tags and bam dma Sricharan R
2016-01-19 10:02 ` [PATCH V7 1/6] i2c: qup: Change qup_wait_writeready function to use for all timeouts Sricharan R
2016-02-12 18:37 ` Wolfram Sang
2016-01-19 10:02 ` [PATCH V7 2/6] i2c: qup: Add V2 tags support Sricharan R
2016-02-12 18:37 ` Wolfram Sang
2016-01-19 10:02 ` [PATCH V7 3/6] i2c: qup: Transfer each i2c_msg in i2c_msgs without a stop bit Sricharan R
2016-01-24 11:29 ` Wolfram Sang
2016-01-28 4:57 ` Sricharan
2016-02-04 20:09 ` Wolfram Sang
2016-02-05 8:00 ` Sricharan
2016-02-12 18:38 ` Wolfram Sang
2016-01-19 10:02 ` [PATCH V7 4/6] i2c: qup: Add bam dma capabilities Sricharan R
2016-02-12 18:37 ` Wolfram Sang
2016-02-12 18:42 ` Wolfram Sang
2016-02-13 6:58 ` Sricharan
2016-02-22 12:24 ` Sricharan
2016-02-22 12:32 ` Wolfram Sang
2016-02-22 13:41 ` Sricharan
2016-01-19 10:02 ` [PATCH V7 5/6] dts: msm8974: Add blsp2_bam dma node Sricharan R
2016-03-25 23:17 ` Bjorn Andersson
2016-03-26 2:26 ` Andy Gross
2016-03-28 12:59 ` Sricharan
2016-01-19 10:02 ` [PATCH V7 6/6] dts: msm8974: Add dma channels for blsp2_i2c1 node Sricharan R
2016-01-19 10:14 ` [PATCH V7 0/6] i2c: qup: Add support for v2 tags and bam dma Sricharan
2016-01-24 11:33 ` Wolfram Sang
2016-01-28 5:27 ` Sricharan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001d01d1598c$a6dc1630$f4944290$@codeaurora.org' \
--to=sricharan@codeaurora.org \
--cc=agross@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=architt@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=iivanov@mm-sol.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ntelkar@codeaurora.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).