From: "Sricharan" <sricharan@codeaurora.org>
To: "'Wolfram Sang'" <wsa@the-dreams.de>
Cc: <devicetree@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
<agross@codeaurora.org>, <linux-kernel@vger.kernel.org>,
<linux-i2c@vger.kernel.org>, <iivanov@mm-sol.com>,
<galak@codeaurora.org>, <dmaengine@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <andy.gross@linaro.org>,
<ntelkar@codeaurora.org>, <architt@codeaurora.org>
Subject: RE: [PATCH V7 4/6] i2c: qup: Add bam dma capabilities
Date: Mon, 22 Feb 2016 17:54:57 +0530 [thread overview]
Message-ID: <002a01d16d6c$0f790520$2e6b0f60$@codeaurora.org> (raw)
In-Reply-To:
Hi Wolfram,
> -----Original Message-----
> From: Sricharan [mailto:sricharan@codeaurora.org]
> Sent: Saturday, February 13, 2016 12:29 PM
> To: 'Wolfram Sang'
> Cc: 'devicetree@vger.kernel.org'; 'linux-arm-msm@vger.kernel.org';
> 'agross@codeaurora.org'; 'linux-kernel@vger.kernel.org'; 'linux-
> i2c@vger.kernel.org'; 'iivanov@mm-sol.com'; 'galak@codeaurora.org';
> 'dmaengine@vger.kernel.org'; 'linux-arm-kernel@lists.infradead.org';
> 'andy.gross@linaro.org'; 'ntelkar@codeaurora.org';
'architt@codeaurora.org'
> Subject: RE: [PATCH V7 4/6] i2c: qup: Add bam dma capabilities
>
> Hi Wolfram,
>
> > -----Original Message-----
> > From: Wolfram Sang [mailto:wsa@the-dreams.de]
> > Sent: Saturday, February 13, 2016 12:08 AM
> > To: Sricharan R
> > Cc: devicetree@vger.kernel.org; linux-arm-msm@vger.kernel.org;
> > agross@codeaurora.org; linux-kernel@vger.kernel.org; linux-
> > i2c@vger.kernel.org; iivanov@mm-sol.com; galak@codeaurora.org;
> > dmaengine@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> > andy.gross@linaro.org; ntelkar@codeaurora.org; architt@codeaurora.org
> > Subject: Re: [PATCH V7 4/6] i2c: qup: Add bam dma capabilities
> >
> > On Tue, Jan 19, 2016 at 03:32:44PM +0530, Sricharan R wrote:
> > > QUP cores can be attached to a BAM module, which acts as a dma
> > > engine for the QUP core. When DMA with BAM is enabled, the BAM
> > > consumer
> > pipe
> > > transmitted data is written to the output FIFO and the BAM producer
> > > pipe received data is read from the input FIFO.
> > >
> > > With BAM capabilities, qup-i2c core can transfer more than
> > > 256 bytes, without a 'stop' which is not possible otherwise.
> > >
> > > Signed-off-by: Sricharan R <sricharan@codeaurora.org>
> > > Reviewed-by: Andy Gross <andy.gross@linaro.org>
> > > Tested-by: Archit Taneja <architt@codeaurora.org>
> > > Tested-by: Telkar Nagender <ntelkar@codeaurora.org>
> >
> > My code checkers found some issues:
> >
> > SPARSE
> > drivers/i2c/busses/i2c-qup.c:555:6: warning: symbol 'qup_sg_set_buf'
> > was not declared. Should it be static?
> > drivers/i2c/busses/i2c-qup.c:1243:50: warning: dubious: !x & !y
> > SMATCH
> > drivers/i2c/busses/i2c-qup.c:165 qup_sg_set_buf warn: unused return: s
> > =
> > sg_next()
> > drivers/i2c/busses/i2c-qup.c:165 qup_sg_set_buf warn: unused return: s
> > =
> > sg_next()
> > drivers/i2c/busses/i2c-qup.c:1243 qup_i2c_xfer_v2() warn: add some
> > parenthesis here?
> > CPPCHECK
> > drivers/i2c/busses/i2c-qup.c:1243: style: Boolean result is used in
> > bitwise operation. Clarify expression with parentheses.
> > SPATCH
> > drivers/i2c/busses/i2c-qup.c:1380:2-13: WARNING: Assignment of bool to
> > 0/1
> > drivers/i2c/busses/i2c-qup.c:1481:1-13: WARNING: Assignment of bool to
> 0/1
> > CC drivers/i2c/busses/i2c-qup.o
> > drivers/i2c/busses/i2c-qup.c:555:6: warning: no previous prototype for
> > 'qup_sg_set_buf' [-Wmissing-prototypes] void qup_sg_set_buf(struct
> > scatterlist *sg, void *buf, struct qup_i2c_tag *tg,
> >
> > Can you fix them and resend??
>
Really sorry for the delay , sent it here [1]
Also, while testing this series in one of a new platform, found that an
additional
Regression and a fix is required on top of this series. So can I send a
separate fix on top of this series ?
[1] https://patchwork.ozlabs.org/patch/586125/
Regards,
Sricharan
next prev parent reply other threads:[~2016-02-22 12:25 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-19 10:02 [PATCH V7 0/6] i2c: qup: Add support for v2 tags and bam dma Sricharan R
2016-01-19 10:02 ` [PATCH V7 1/6] i2c: qup: Change qup_wait_writeready function to use for all timeouts Sricharan R
2016-02-12 18:37 ` Wolfram Sang
2016-01-19 10:02 ` [PATCH V7 2/6] i2c: qup: Add V2 tags support Sricharan R
2016-02-12 18:37 ` Wolfram Sang
2016-01-19 10:02 ` [PATCH V7 3/6] i2c: qup: Transfer each i2c_msg in i2c_msgs without a stop bit Sricharan R
2016-01-24 11:29 ` Wolfram Sang
2016-01-28 4:57 ` Sricharan
2016-02-04 20:09 ` Wolfram Sang
2016-02-05 8:00 ` Sricharan
2016-02-12 18:38 ` Wolfram Sang
2016-01-19 10:02 ` [PATCH V7 4/6] i2c: qup: Add bam dma capabilities Sricharan R
2016-02-12 18:37 ` Wolfram Sang
2016-02-12 18:42 ` Wolfram Sang
2016-02-13 6:58 ` Sricharan
2016-02-22 12:24 ` Sricharan [this message]
2016-02-22 12:32 ` Wolfram Sang
2016-02-22 13:41 ` Sricharan
2016-01-19 10:02 ` [PATCH V7 5/6] dts: msm8974: Add blsp2_bam dma node Sricharan R
2016-03-25 23:17 ` Bjorn Andersson
2016-03-26 2:26 ` Andy Gross
2016-03-28 12:59 ` Sricharan
2016-01-19 10:02 ` [PATCH V7 6/6] dts: msm8974: Add dma channels for blsp2_i2c1 node Sricharan R
2016-01-19 10:14 ` [PATCH V7 0/6] i2c: qup: Add support for v2 tags and bam dma Sricharan
2016-01-24 11:33 ` Wolfram Sang
2016-01-28 5:27 ` Sricharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002a01d16d6c$0f790520$2e6b0f60$@codeaurora.org' \
--to=sricharan@codeaurora.org \
--cc=agross@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=architt@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=iivanov@mm-sol.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ntelkar@codeaurora.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).