From: Matthew Wilcox <matthew.r.wilcox@intel.com>
To: Konstantin Khlebnikov <koct9i@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Matthew Wilcox <matthew.r.wilcox@intel.com>,
Hugh Dickins <hughd@google.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org
Subject: [PATCH 0/2] Radix tree retry bug fix & test case
Date: Thu, 4 Feb 2016 22:40:46 -0500 [thread overview]
Message-ID: <1454643648-10002-1-git-send-email-matthew.r.wilcox@intel.com> (raw)
Konstantin pointed out my braino when using radix_tree_iter_retry(),
and then pointed out a second braino. I think we can fix both brainos
with one simple test (the advantage of having your braino pointed out
to you is that you know what you were expecting to happen, so you can
sometimes propose simlpy making happen what you expected to happen.
Konstantin doesn't have access to my though tprocesses.)
Kontantin wrote a really great test ... and then didn't add it to the
test suite. That made me sad, so I added it.
Andrew, can you drop radix-tree-fix-oops-after-radix_tree_iter_retry.patch
from your tree and add these two patches instead? If you prefer
Konstantin's fix to this one, I'll send you another patch to fix the
second problem Konstantin pointed out.
I was a bit unsure about the proper attribution here. The essentials
of the test-suite change from Konstantin are unchanged, but he didn't
have his own sign-off on it. So I made him 'From' and only added my
own sign-off.
Konstantin Khlebnikov (1):
radix-tree tests: Add regression3 test
Matthew Wilcox (1):
radix-tree: fix oops after radix_tree_iter_retry
include/linux/radix-tree.h | 3 ++
tools/testing/radix-tree/Makefile | 2 +-
tools/testing/radix-tree/linux/kernel.h | 1 +
tools/testing/radix-tree/main.c | 1 +
tools/testing/radix-tree/regression.h | 1 +
tools/testing/radix-tree/regression3.c | 86 +++++++++++++++++++++++++++++++++
6 files changed, 93 insertions(+), 1 deletion(-)
create mode 100644 tools/testing/radix-tree/regression3.c
--
2.7.0.rc3
next reply other threads:[~2016-02-05 3:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-05 3:40 Matthew Wilcox [this message]
2016-02-05 3:40 ` [PATCH 1/2] radix-tree tests: Add regression3 test Matthew Wilcox
2016-02-05 3:40 ` [PATCH 2/2] radix-tree: fix oops after radix_tree_iter_retry Matthew Wilcox
2016-02-05 4:56 ` [PATCH 0/2] Radix tree retry bug fix & test case Konstantin Khlebnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454643648-10002-1-git-send-email-matthew.r.wilcox@intel.com \
--to=matthew.r.wilcox@intel.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=koct9i@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).