From: Konstantin Khlebnikov <koct9i@gmail.com>
To: Matthew Wilcox <matthew.r.wilcox@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hughd@google.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH 0/2] Radix tree retry bug fix & test case
Date: Fri, 5 Feb 2016 07:56:07 +0300 [thread overview]
Message-ID: <CALYGNiPopvgU0xqpykK2MfB3ejh_mq5M99FB4D47F11h3Entgg@mail.gmail.com> (raw)
In-Reply-To: <1454643648-10002-1-git-send-email-matthew.r.wilcox@intel.com>
On Fri, Feb 5, 2016 at 6:40 AM, Matthew Wilcox
<matthew.r.wilcox@intel.com> wrote:
> Konstantin pointed out my braino when using radix_tree_iter_retry(),
> and then pointed out a second braino. I think we can fix both brainos
> with one simple test (the advantage of having your braino pointed out
> to you is that you know what you were expecting to happen, so you can
> sometimes propose simlpy making happen what you expected to happen.
> Konstantin doesn't have access to my though tprocesses.)
>
> Kontantin wrote a really great test ... and then didn't add it to the
> test suite. That made me sad, so I added it.
I haven't seen them, I wasn't in CC. And I prefer testing in vivo if possible.
>
> Andrew, can you drop radix-tree-fix-oops-after-radix_tree_iter_retry.patch
> from your tree and add these two patches instead? If you prefer
> Konstantin's fix to this one, I'll send you another patch to fix the
> second problem Konstantin pointed out.
Nak. Mine version generates better code. radix_tree_next_slot is a hot place.
Please fix second problem in your helper separately.
>
> I was a bit unsure about the proper attribution here. The essentials
> of the test-suite change from Konstantin are unchanged, but he didn't
> have his own sign-off on it. So I made him 'From' and only added my
> own sign-off.
>
> Konstantin Khlebnikov (1):
> radix-tree tests: Add regression3 test
>
> Matthew Wilcox (1):
> radix-tree: fix oops after radix_tree_iter_retry
>
> include/linux/radix-tree.h | 3 ++
> tools/testing/radix-tree/Makefile | 2 +-
> tools/testing/radix-tree/linux/kernel.h | 1 +
> tools/testing/radix-tree/main.c | 1 +
> tools/testing/radix-tree/regression.h | 1 +
> tools/testing/radix-tree/regression3.c | 86 +++++++++++++++++++++++++++++++++
> 6 files changed, 93 insertions(+), 1 deletion(-)
> create mode 100644 tools/testing/radix-tree/regression3.c
>
> --
> 2.7.0.rc3
>
prev parent reply other threads:[~2016-02-05 4:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-05 3:40 [PATCH 0/2] Radix tree retry bug fix & test case Matthew Wilcox
2016-02-05 3:40 ` [PATCH 1/2] radix-tree tests: Add regression3 test Matthew Wilcox
2016-02-05 3:40 ` [PATCH 2/2] radix-tree: fix oops after radix_tree_iter_retry Matthew Wilcox
2016-02-05 4:56 ` Konstantin Khlebnikov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALYGNiPopvgU0xqpykK2MfB3ejh_mq5M99FB4D47F11h3Entgg@mail.gmail.com \
--to=koct9i@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=matthew.r.wilcox@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).