[PATCH net-next] net: openvswitch: Release reference to netdev

* [PATCH net-next] net: openvswitch: Release reference to netdev
@ 2024-04-23  7:37 Jun Gu
  2024-04-23 11:15 ` [ovs-dev] " Simon Horman
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Jun Gu @ 2024-04-23  7:37 UTC (permalink / raw)
  To: pshelar; +Cc: netdev, dev, linux-kernel, Jun Gu

dev_get_by_name will provide a reference on the netdev. So ensure that
the reference of netdev is released after completed.

Fixes: 2540088b836f ("net: openvswitch: Check vport netdev name")
Signed-off-by: Jun Gu <jun.gu@easystack.cn>
---
 net/openvswitch/vport-netdev.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/net/openvswitch/vport-netdev.c b/net/openvswitch/vport-netdev.c
index 618edc346c0f..91a11067e458 100644
--- a/net/openvswitch/vport-netdev.c
+++ b/net/openvswitch/vport-netdev.c
@@ -78,12 +78,16 @@ struct vport *ovs_netdev_link(struct vport *vport, const char *name)
 	int err;
 
 	vport->dev = dev_get_by_name(ovs_dp_get_net(vport->dp), name);
+	if (!vport->dev) {
+		err = -ENODEV;
+		goto error_free_vport;
+	}
 	/* Ensure that the device exists and that the provided
 	 * name is not one of its aliases.
 	 */
-	if (!vport->dev || strcmp(name, ovs_vport_name(vport))) {
+	if (strcmp(name, ovs_vport_name(vport))) {
 		err = -ENODEV;
-		goto error_free_vport;
+		goto error_put;
 	}
 	netdev_tracker_alloc(vport->dev, &vport->dev_tracker, GFP_KERNEL);
 	if (vport->dev->flags & IFF_LOOPBACK ||
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread