From: Lee Jones <lee.jones@linaro.org>
To: Wenyou Yang <wenyou.yang@atmel.com>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Brown <broonie@kernel.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Javier Martinez Canillas <javier@dowhile0.org>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Peter Korsgaard <jacmet@gmail.com>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v10 2/2] mfd: add documentation for ACT8945A DT bindings
Date: Wed, 10 Feb 2016 16:55:24 +0000 [thread overview]
Message-ID: <20160210165524.GQ3782@x1> (raw)
In-Reply-To: <1454643390-16910-3-git-send-email-wenyou.yang@atmel.com>
On Fri, 05 Feb 2016, Wenyou Yang wrote:
> The Active-semi ACT8945A PMIC is a Multi-Function Device, it has
> two subdevices:
> - Regulator
> - Charger
>
> This patch adds documentation for ACT8945A DT bindings.
>
> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> Acked-by: Rob Herring <robh@kernel.org>
> Acked-by: Lee Jones <lee.jones@linaro.org>
> ---
>
> Changes in v10:
> - update the example, due to the subdevices are not regarded as
> a child node.
v9 unapplied, v10 applied.
> Changes in v9: None
> Changes in v8: None
> Changes in v7:
> - collect Acked-by from Lee Jones
>
> Changes in v6:
> - change the regulator name.
>
> Changes in v5: None
> Changes in v4: None
> Changes in v3:
> - fix the tabbing errors in Example.
> - use "pmic@5b" label, not "act8945a@5b" in Example.
> - collect Acked-by from Rob.
>
> Changes in v2:
> - use more specific label in Example.
> - add pmic and charger nodes in Example.
>
> Documentation/devicetree/bindings/mfd/act8945a.txt | 76 ++++++++++++++++++++
> 1 file changed, 76 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/act8945a.txt
>
> diff --git a/Documentation/devicetree/bindings/mfd/act8945a.txt b/Documentation/devicetree/bindings/mfd/act8945a.txt
> new file mode 100644
> index 0000000..f712830
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/act8945a.txt
> @@ -0,0 +1,76 @@
> +Device-Tree bindings for Active-semi ACT8945A MFD driver
> +
> +Required properties:
> + - compatible: "active-semi,act8945a".
> + - reg: the I2C slave address for the ACT8945A chip
> +
> +The chip exposes two subdevices:
> + - a regulators: see ../regulator/act8945a-regulator.txt
> + - a charger: see ../power/act8945a-charger.txt
> +
> +Example:
> + pmic@5b {
> + compatible = "active-semi,act8945a";
> + reg = <0x5b>;
> + status = "okay";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_charger_chglev>;
> + active-semi,chglev-gpio = <&pioA 12 GPIO_ACTIVE_HIGH>;
> + active-semi,input-voltage-threshold-microvolt = <6600>;
> + active-semi,precondition-timeout = <40>;
> + active-semi,total-timeout = <3>;
> +
> + active-semi,vsel-high;
> +
> + regulators {
> + vdd_1v35_reg: REG_DCDC1 {
> + regulator-name = "VDD_1V35";
> + regulator-min-microvolt = <1350000>;
> + regulator-max-microvolt = <1350000>;
> + regulator-always-on;
> + };
> +
> + vdd_1v2_reg: REG_DCDC2 {
> + regulator-name = "VDD_1V2";
> + regulator-min-microvolt = <1100000>;
> + regulator-max-microvolt = <1300000>;
> + regulator-always-on;
> + };
> +
> + vdd_3v3_reg: REG_DCDC3 {
> + regulator-name = "VDD_3V3";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-always-on;
> + };
> +
> + vdd_fuse_reg: REG_LDO1 {
> + regulator-name = "VDD_FUSE";
> + regulator-min-microvolt = <2500000>;
> + regulator-max-microvolt = <2500000>;
> + regulator-always-on;
> + };
> +
> + vdd_3v3_lp_reg: REG_LDO2 {
> + regulator-name = "VDD_3V3_LP";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-always-on;
> + };
> +
> + vdd_led_reg: REG_LDO3 {
> + regulator-name = "VDD_LED";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-always-on;
> + };
> +
> + vdd_sdhc_1v8_reg: REG_LDO4 {
> + regulator-name = "VDD_SDHC_1V8";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-always-on;
> + };
> + };
> + };
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2016-02-10 16:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-05 3:36 [PATCH v10 0/2] mfd: act8945a: add Active-semi ACT8945A PMIC MFD driver Wenyou Yang
2016-02-05 3:36 ` [PATCH v10 1/2] " Wenyou Yang
2016-02-10 16:55 ` Lee Jones
2016-02-05 3:36 ` [PATCH v10 2/2] mfd: add documentation for ACT8945A DT bindings Wenyou Yang
2016-02-10 16:55 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160210165524.GQ3782@x1 \
--to=lee.jones@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jacmet@gmail.com \
--cc=javier@dowhile0.org \
--cc=k.kozlowski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=wenyou.yang@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).