From: Herbert Xu <herbert@gondor.apana.org.au>
To: Meng Yu <yumeng18@huawei.com>
Cc: davem@davemloft.net, linux-crypto@vger.kernel.org,
xuzaibo@huawei.com, wangzhou1@hisilicon.com,
linux-kernel@vger.kernel.org, shenyang39@huawei.com
Subject: Re: [PATCH] crypto: hisilicon/hpre - rsa key should not be empty
Date: Fri, 2 Apr 2021 18:12:26 +1100 [thread overview]
Message-ID: <20210402071225.GA10423@gondor.apana.org.au> (raw)
In-Reply-To: <1616739212-7751-1-git-send-email-yumeng18@huawei.com>
On Fri, Mar 26, 2021 at 02:13:32PM +0800, Meng Yu wrote:
> We should ensure key is not empty before we set key.
>
> Signed-off-by: Meng Yu <yumeng18@huawei.com>
> ---
> drivers/crypto/hisilicon/hpre/hpre_crypto.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/crypto/hisilicon/hpre/hpre_crypto.c b/drivers/crypto/hisilicon/hpre/hpre_crypto.c
> index 53068d2..7cf7d80 100644
> --- a/drivers/crypto/hisilicon/hpre/hpre_crypto.c
> +++ b/drivers/crypto/hisilicon/hpre/hpre_crypto.c
> @@ -1093,6 +1093,9 @@ static int hpre_rsa_setpubkey(struct crypto_akcipher *tfm, const void *key,
> struct hpre_ctx *ctx = akcipher_tfm_ctx(tfm);
> int ret;
>
> + if (!key || !keylen)
> + return -EINVAL;
> +
> ret = crypto_akcipher_set_pub_key(ctx->rsa.soft_tfm, key, keylen);
Does this fix a real bug? Wouldn't the soft fallback setkey catch
this anyhow?
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2021-04-02 7:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 6:13 [PATCH] crypto: hisilicon/hpre - rsa key should not be empty Meng Yu
2021-04-02 7:12 ` Herbert Xu [this message]
2021-04-02 10:16 ` yumeng
2021-04-02 10:22 ` Herbert Xu
2021-04-06 0:51 ` yumeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210402071225.GA10423@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shenyang39@huawei.com \
--cc=wangzhou1@hisilicon.com \
--cc=xuzaibo@huawei.com \
--cc=yumeng18@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).