From: yumeng <yumeng18@huawei.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: <davem@davemloft.net>, <linux-crypto@vger.kernel.org>,
<xuzaibo@huawei.com>, <wangzhou1@hisilicon.com>,
<linux-kernel@vger.kernel.org>, <shenyang39@huawei.com>
Subject: Re: [PATCH] crypto: hisilicon/hpre - rsa key should not be empty
Date: Tue, 6 Apr 2021 08:51:56 +0800 [thread overview]
Message-ID: <639630ef-f0c3-1ccb-983d-0cb9d2ac2952@huawei.com> (raw)
In-Reply-To: <20210402102223.GA24978@gondor.apana.org.au>
在 2021/4/2 18:22, Herbert Xu 写道:
> On Fri, Apr 02, 2021 at 06:16:16PM +0800, yumeng wrote:
>>
>> I think it is not a real bug, and soft fallback setkey can always catch the
>> error.
>> But our original intention was to make it don't go to 'xxx_set_pub_key'
>> when the key is null, and it can return an error earlier.
>> But maybe it is not good.
>
> It might make sense to check them twice if you were touching them
> directly, e.g., poking inside the key. However, it appears that
> your driver simply palms off the key to rsa_helper.c which should
> check the key/keylen too so I think there is no need for this patch
> for now.
>
> Thanks,
>
OK, thank you.
prev parent reply other threads:[~2021-04-06 0:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 6:13 [PATCH] crypto: hisilicon/hpre - rsa key should not be empty Meng Yu
2021-04-02 7:12 ` Herbert Xu
2021-04-02 10:16 ` yumeng
2021-04-02 10:22 ` Herbert Xu
2021-04-06 0:51 ` yumeng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=639630ef-f0c3-1ccb-983d-0cb9d2ac2952@huawei.com \
--to=yumeng18@huawei.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shenyang39@huawei.com \
--cc=wangzhou1@hisilicon.com \
--cc=xuzaibo@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).