From: kernel test robot <lkp@intel.com>
To: Xiaofei Tan <tanxiaofei@huawei.com>,
gregkh@linuxfoundation.org, jirislaby@kernel.org
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
linux-kernel@vger.kernel.org, linuxarm@openeuler.org,
Xiaofei Tan <tanxiaofei@huawei.com>
Subject: Re: [PATCH 02/10] tty/sysrq: Fix issues of code indent should use tabs
Date: Mon, 5 Apr 2021 14:36:33 +0800 [thread overview]
Message-ID: <202104051457.fT0BXELo-lkp@intel.com> (raw)
In-Reply-To: <1617593662-25900-3-git-send-email-tanxiaofei@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 3465 bytes --]
Hi Xiaofei,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on tty/tty-testing]
[also build test WARNING on v5.12-rc6 next-20210401]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Xiaofei-Tan/tty-Fix-some-coding-style-issues/20210405-113900
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
config: x86_64-randconfig-a004-20210405 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 2760a808b9916a2839513b7fd7314a464f52481e)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://github.com/0day-ci/linux/commit/da18c35dce46cd938810b3ca12275fac9c97f64d
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Xiaofei-Tan/tty-Fix-some-coding-style-issues/20210405-113900
git checkout da18c35dce46cd938810b3ca12275fac9c97f64d
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/tty/sysrq.c:558:3: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation]
return op_p;
^
drivers/tty/sysrq.c:555:2: note: previous statement is here
if (i != -1)
^
1 warning generated.
vim +/if +558 drivers/tty/sysrq.c
^1da177e4c3f41 drivers/char/sysrq.c Linus Torvalds 2005-04-16 545
^1da177e4c3f41 drivers/char/sysrq.c Linus Torvalds 2005-04-16 546 /*
^1da177e4c3f41 drivers/char/sysrq.c Linus Torvalds 2005-04-16 547 * get and put functions for the table, exposed to modules.
^1da177e4c3f41 drivers/char/sysrq.c Linus Torvalds 2005-04-16 548 */
23cbedf812ff7c drivers/tty/sysrq.c Emil Velikov 2020-05-13 549 static const struct sysrq_key_op *__sysrq_get_key_op(int key)
bf36b9011e3c5b drivers/char/sysrq.c Andrew Morton 2006-03-25 550 {
23cbedf812ff7c drivers/tty/sysrq.c Emil Velikov 2020-05-13 551 const struct sysrq_key_op *op_p = NULL;
^1da177e4c3f41 drivers/char/sysrq.c Linus Torvalds 2005-04-16 552 int i;
^1da177e4c3f41 drivers/char/sysrq.c Linus Torvalds 2005-04-16 553
^1da177e4c3f41 drivers/char/sysrq.c Linus Torvalds 2005-04-16 554 i = sysrq_key_table_key2index(key);
bf36b9011e3c5b drivers/char/sysrq.c Andrew Morton 2006-03-25 555 if (i != -1)
bf36b9011e3c5b drivers/char/sysrq.c Andrew Morton 2006-03-25 556 op_p = sysrq_key_table[i];
97f5f0cd8cd0a0 drivers/char/sysrq.c Dmitry Torokhov 2010-03-21 557
^1da177e4c3f41 drivers/char/sysrq.c Linus Torvalds 2005-04-16 @558 return op_p;
^1da177e4c3f41 drivers/char/sysrq.c Linus Torvalds 2005-04-16 559 }
^1da177e4c3f41 drivers/char/sysrq.c Linus Torvalds 2005-04-16 560
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 27615 bytes --]
next prev parent reply other threads:[~2021-04-05 6:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-05 3:34 [PATCH 00/10] tty: Fix some coding style issues Xiaofei Tan
2021-04-05 3:34 ` [PATCH 01/10] tty/sysrq: Add a blank line after declarations Xiaofei Tan
2021-04-05 3:34 ` [PATCH 02/10] tty/sysrq: Fix issues of code indent should use tabs Xiaofei Tan
2021-04-05 6:36 ` kernel test robot [this message]
2021-04-05 7:57 ` kernel test robot
2021-04-05 9:03 ` Xiaofei Tan
2021-04-09 8:35 ` [kbuild] " Dan Carpenter
2021-04-05 3:34 ` [PATCH 03/10] tty: tty_jobctrl: Add a blank line after declarations Xiaofei Tan
2021-04-05 3:34 ` [PATCH 04/10] tty: tty_jobctrl: Fix coding style issues of block comments Xiaofei Tan
2021-04-06 4:42 ` Jiri Slaby
2021-04-06 6:22 ` Xiaofei Tan
2021-04-05 3:34 ` [PATCH 05/10] tty: tty_jobctrl: Remove spaces before tabs Xiaofei Tan
2021-04-05 3:34 ` [PATCH 06/10] tty: tty_ldisc: Fix an issue of code indent should use tabs Xiaofei Tan
2021-04-05 3:34 ` [PATCH 07/10] tty: tty_ldisc: Add a blank line after declarations Xiaofei Tan
2021-04-05 3:34 ` [PATCH 08/10] tty: tty_ldisc: Fix coding style issues of block comments Xiaofei Tan
2021-04-05 3:34 ` [PATCH 09/10] tty: tty_ldisc: Do not use assignment in if condition Xiaofei Tan
2021-04-05 3:34 ` [PATCH 10/10] tty: tty_ldisc: Remove the repeated word 'the' Xiaofei Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202104051457.fT0BXELo-lkp@intel.com \
--to=lkp@intel.com \
--cc=clang-built-linux@googlegroups.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@openeuler.org \
--cc=tanxiaofei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).