LKML Archive mirror
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org, Xiaofei Tan <tanxiaofei@huawei.com>,
	gregkh@linuxfoundation.org, jirislaby@kernel.org
Cc: lkp@intel.com, kbuild-all@lists.01.org,
	linux-kernel@vger.kernel.org, linuxarm@openeuler.org,
	Xiaofei Tan <tanxiaofei@huawei.com>
Subject: [kbuild] Re: [PATCH 02/10] tty/sysrq: Fix issues of code indent should use tabs
Date: Fri, 9 Apr 2021 11:35:12 +0300	[thread overview]
Message-ID: <20210409083512.GD6048@kadam> (raw)
In-Reply-To: <1617593662-25900-3-git-send-email-tanxiaofei@huawei.com>

[-- Attachment #1: Type: text/plain, Size: 1793 bytes --]

Hi Xiaofei,

url:    https://github.com/0day-ci/linux/commits/Xiaofei-Tan/tty-Fix-some-coding-style-issues/20210405-113900
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git  tty-testing
config: x86_64-randconfig-m001-20210405 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/tty/sysrq.c:558 __sysrq_get_key_op() warn: curly braces intended?

vim +558 drivers/tty/sysrq.c

23cbedf812ff7c drivers/tty/sysrq.c  Emil Velikov    2020-05-13  549  static const struct sysrq_key_op *__sysrq_get_key_op(int key)
bf36b9011e3c5b drivers/char/sysrq.c Andrew Morton   2006-03-25  550  {
23cbedf812ff7c drivers/tty/sysrq.c  Emil Velikov    2020-05-13  551  	const struct sysrq_key_op *op_p = NULL;
^1da177e4c3f41 drivers/char/sysrq.c Linus Torvalds  2005-04-16  552  	int i;
^1da177e4c3f41 drivers/char/sysrq.c Linus Torvalds  2005-04-16  553  
^1da177e4c3f41 drivers/char/sysrq.c Linus Torvalds  2005-04-16  554  	i = sysrq_key_table_key2index(key);
bf36b9011e3c5b drivers/char/sysrq.c Andrew Morton   2006-03-25  555  	if (i != -1)
bf36b9011e3c5b drivers/char/sysrq.c Andrew Morton   2006-03-25  556  		op_p = sysrq_key_table[i];
97f5f0cd8cd0a0 drivers/char/sysrq.c Dmitry Torokhov 2010-03-21  557  
^1da177e4c3f41 drivers/char/sysrq.c Linus Torvalds  2005-04-16 @558  		return op_p;
                                                                                ^^^^^^^^^^^
indented too far.

^1da177e4c3f41 drivers/char/sysrq.c Linus Torvalds  2005-04-16  559  }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org 

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 39178 bytes --]

[-- Attachment #3: Type: text/plain, Size: 149 bytes --]

_______________________________________________
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-leave@lists.01.org

  parent reply	other threads:[~2021-04-09  8:39 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-05  3:34 [PATCH 00/10] tty: Fix some coding style issues Xiaofei Tan
2021-04-05  3:34 ` [PATCH 01/10] tty/sysrq: Add a blank line after declarations Xiaofei Tan
2021-04-05  3:34 ` [PATCH 02/10] tty/sysrq: Fix issues of code indent should use tabs Xiaofei Tan
2021-04-05  6:36   ` kernel test robot
2021-04-05  7:57   ` kernel test robot
2021-04-05  9:03   ` Xiaofei Tan
2021-04-09  8:35   ` Dan Carpenter [this message]
2021-04-05  3:34 ` [PATCH 03/10] tty: tty_jobctrl: Add a blank line after declarations Xiaofei Tan
2021-04-05  3:34 ` [PATCH 04/10] tty: tty_jobctrl: Fix coding style issues of block comments Xiaofei Tan
2021-04-06  4:42   ` Jiri Slaby
2021-04-06  6:22     ` Xiaofei Tan
2021-04-05  3:34 ` [PATCH 05/10] tty: tty_jobctrl: Remove spaces before tabs Xiaofei Tan
2021-04-05  3:34 ` [PATCH 06/10] tty: tty_ldisc: Fix an issue of code indent should use tabs Xiaofei Tan
2021-04-05  3:34 ` [PATCH 07/10] tty: tty_ldisc: Add a blank line after declarations Xiaofei Tan
2021-04-05  3:34 ` [PATCH 08/10] tty: tty_ldisc: Fix coding style issues of block comments Xiaofei Tan
2021-04-05  3:34 ` [PATCH 09/10] tty: tty_ldisc: Do not use assignment in if condition Xiaofei Tan
2021-04-05  3:34 ` [PATCH 10/10] tty: tty_ldisc: Remove the repeated word 'the' Xiaofei Tan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210409083512.GD6048@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=kbuild-all@lists.01.org \
    --cc=kbuild@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxarm@openeuler.org \
    --cc=lkp@intel.com \
    --cc=tanxiaofei@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).