From: Charlie Johnston <charlie.johnston@ni.com>
To: giometti@enneenne.com
Cc: linux-kernel@vger.kernel.org, brenda.streiff@ni.com,
Charlie Johnston <charlie.johnston@ni.com>
Subject: [RFC PATCH] pps: Increase PPS_MAX_SOURCES value.
Date: Mon, 5 Jun 2023 15:31:47 -0500 [thread overview]
Message-ID: <20230605203147.694716-1-charlie.johnston@ni.com> (raw)
For consistency with what ptp uses for minors, this
change sets PPS_MAX_SOURCES to MINORMASK + 1.
The PPS_MAX_SOURCES value is currently set to 16. In
some cases this was not sufficient for a system. For
example, a system with multiple (4+) PCIe cards each
with 4 PTP-capable ethernet interfaces could run out
of the available PPS major:minors if each interface
registers a PPS source.
Signed-off-by: Charlie Johnston <charlie.johnston@ni.com>
---
include/uapi/linux/pps.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/linux/pps.h b/include/uapi/linux/pps.h
index 009ebcd8ced5..85f472330da8 100644
--- a/include/uapi/linux/pps.h
+++ b/include/uapi/linux/pps.h
@@ -26,7 +26,7 @@
#include <linux/types.h>
#define PPS_VERSION "5.3.6"
-#define PPS_MAX_SOURCES 16 /* should be enough... */
+#define PPS_MAX_SOURCES (MINORMASK + 1)
/* Implementation note: the logical states ``assert'' and ``clear''
* are implemented in terms of the chip register, i.e. ``assert''
--
2.30.2
next reply other threads:[~2023-06-05 21:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 20:31 Charlie Johnston [this message]
2023-06-07 7:33 ` [RFC PATCH] pps: Increase PPS_MAX_SOURCES value Rodolfo Giometti
2023-06-07 22:07 ` Charlie Johnston
2023-06-09 7:30 ` Rodolfo Giometti
2023-06-09 21:00 ` Charlie Johnston
2023-06-12 16:07 ` Rodolfo Giometti
2023-06-20 20:42 ` Charlie Johnston
2023-06-21 15:31 ` Rodolfo Giometti
2023-06-23 2:03 ` Charlie Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230605203147.694716-1-charlie.johnston@ni.com \
--to=charlie.johnston@ni.com \
--cc=brenda.streiff@ni.com \
--cc=giometti@enneenne.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).