From: Conor Dooley <conor@kernel.org>
To: Javier Martinez Canillas <javierm@redhat.com>
Cc: linux-kernel@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Maxime Ripard <mripard@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 2/5] dt-bindings: display: ssd1307fb: Remove default width and height values
Date: Sat, 10 Jun 2023 16:10:14 +0100 [thread overview]
Message-ID: <20230610-opposite-quality-81d4a1561c88@spud> (raw)
In-Reply-To: <20230609170941.1150941-3-javierm@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 3653 bytes --]
On Fri, Jun 09, 2023 at 07:09:37PM +0200, Javier Martinez Canillas wrote:
> A default resolution in the ssd130x driver isn't set to an arbitrary 96x16
> anymore. Instead is set to a width and height that's controller dependent.
Did that change to the driver not break backwards compatibility with
existing devicetrees that relied on the default values to get 96x16?
Cheers,
Conor.
>
> The datasheets for the chips describes the following display resolutions:
>
> - SH1106: 132 x 64 Dot Matrix OLED/PLED
> - SSD1305: 132 x 64 Dot Matrix OLED/PLED
> - SSD1306: 128 x 64 Dot Matrix OLED/PLED
> - SSD1307: 128 x 39 Dot Matrix OLED/PLED
> - SSD1309: 128 x 64 Dot Matrix OLED/PLED
>
> Update DT schema to reflect what the driver does and make its users aware.
>
> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
>
> Changes in v2:
> - List per controller default width/height values in DT schema (Maxime Ripard).
>
> .../bindings/display/solomon,ssd1307fb.yaml | 28 ++++++++++++++++---
> 1 file changed, 24 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml b/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml
> index 94bb5ef567c6..20e2bd15d4d2 100644
> --- a/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml
> +++ b/Documentation/devicetree/bindings/display/solomon,ssd1307fb.yaml
> @@ -49,15 +49,15 @@ properties:
>
> solomon,height:
> $ref: /schemas/types.yaml#/definitions/uint32
> - default: 16
> description:
> - Height in pixel of the screen driven by the controller
> + Height in pixel of the screen driven by the controller.
> + The default value is controller-dependent.
>
> solomon,width:
> $ref: /schemas/types.yaml#/definitions/uint32
> - default: 96
> description:
> - Width in pixel of the screen driven by the controller
> + Width in pixel of the screen driven by the controller.
> + The default value is controller-dependent.
>
> solomon,page-offset:
> $ref: /schemas/types.yaml#/definitions/uint32
> @@ -157,6 +157,10 @@ allOf:
> const: sinowealth,sh1106
> then:
> properties:
> + width:
> + default: 132
> + height:
> + default: 64
> solomon,dclk-div:
> default: 1
> solomon,dclk-frq:
> @@ -171,6 +175,10 @@ allOf:
> - solomon,ssd1305
> then:
> properties:
> + width:
> + default: 132
> + height:
> + default: 64
> solomon,dclk-div:
> default: 1
> solomon,dclk-frq:
> @@ -185,6 +193,10 @@ allOf:
> - solomon,ssd1306
> then:
> properties:
> + width:
> + default: 128
> + height:
> + default: 64
> solomon,dclk-div:
> default: 1
> solomon,dclk-frq:
> @@ -199,6 +211,10 @@ allOf:
> - solomon,ssd1307
> then:
> properties:
> + width:
> + default: 128
> + height:
> + default: 39
> solomon,dclk-div:
> default: 2
> solomon,dclk-frq:
> @@ -215,6 +231,10 @@ allOf:
> - solomon,ssd1309
> then:
> properties:
> + width:
> + default: 128
> + height:
> + default: 64
> solomon,dclk-div:
> default: 1
> solomon,dclk-frq:
> --
> 2.40.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-06-10 15:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 17:09 [PATCH v2 0/5] drm/ssd130x: A few enhancements and cleanups Javier Martinez Canillas
2023-06-09 17:09 ` [PATCH v2 1/5] drm/ssd130x: Make default width and height to be controller dependent Javier Martinez Canillas
2023-06-09 17:09 ` [PATCH v2 2/5] dt-bindings: display: ssd1307fb: Remove default width and height values Javier Martinez Canillas
2023-06-10 15:10 ` Conor Dooley [this message]
2023-06-10 17:51 ` Javier Martinez Canillas
2023-06-10 18:14 ` Conor Dooley
2023-06-10 23:18 ` Javier Martinez Canillas
2023-06-12 7:47 ` Thomas Zimmermann
2023-06-12 17:44 ` Conor Dooley
2023-06-12 18:30 ` Javier Martinez Canillas
2023-06-09 17:09 ` [PATCH v2 3/5] drm/ssd130x: Set the page height value in the device info data Javier Martinez Canillas
2023-06-09 17:09 ` [PATCH v2 4/5] drm/ssd130x: Don't allocate buffers on each plane update Javier Martinez Canillas
2023-07-13 12:44 ` Geert Uytterhoeven
2023-07-13 13:15 ` Javier Martinez Canillas
2023-07-13 13:25 ` Geert Uytterhoeven
2023-07-13 14:12 ` Javier Martinez Canillas
2023-07-13 14:53 ` Geert Uytterhoeven
2023-07-13 16:34 ` Javier Martinez Canillas
2023-06-09 17:09 ` [PATCH v2 5/5] drm/ssd130x: Remove hardcoded bits-per-pixel in ssd130x_buf_alloc() Javier Martinez Canillas
2023-07-12 10:24 ` Geert Uytterhoeven
2023-06-15 21:53 ` [PATCH v2 0/5] drm/ssd130x: A few enhancements and cleanups Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230610-opposite-quality-81d4a1561c88@spud \
--to=conor@kernel.org \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=javierm@redhat.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).