From: Steven Rostedt <rostedt@goodmis.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux Trace Kernel <linux-trace-kernel@vger.kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
Mark Rutland <mark.rutland@arm.com>,
Kees Cook <keescook@chromium.org>,
Miguel Ojeda <ojeda@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Ingo Molnar <mingo@kernel.org>, Song Liu <song@kernel.org>,
Josh Poimboeuf <jpoimboe@kernel.org>
Subject: Re: [PATCH v2] ftrace: Allow inline functions not inlined to be traced
Date: Tue, 13 Jun 2023 11:40:49 -0400 [thread overview]
Message-ID: <20230613114049.096a8844@gandalf.local.home> (raw)
In-Reply-To: <87lego7m50.ffs@tglx>
On Mon, 12 Jun 2023 17:09:31 +0200
Thomas Gleixner <tglx@linutronix.de> wrote:
> >
> > Currently only x86 uses this.
>
> I assume this passes the objtool noinstr validation. If so, if would be
> helpful to document that.
I haven't run this through the full test suite. But I will check.
> > /*
> > * gcc provides both __inline__ and __inline as alternate spellings of
> > @@ -230,7 +240,7 @@ struct ftrace_likely_data {
> > * https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67368
> > * '__maybe_unused' allows us to avoid defined-but-not-used warnings.
> > */
> > -# define __no_kasan_or_inline __no_sanitize_address notrace __maybe_unused
> > +# define __no_kasan_or_inline __no_sanitize_address __notrace_inline __maybe_unused
>
> I'm not convinced that this is correct
>
> > # define __no_sanitize_or_inline __no_kasan_or_inline
> > #else
>
> given that the !__SANITIZE_ADDRESS__ variant is:
>
> > # define __no_kasan_or_inline __always_inline
>
> which cannot be traced.
>
> > @@ -247,7 +257,7 @@ struct ftrace_likely_data {
> > * disable all instrumentation. See Kconfig.kcsan where this is mandatory.
> > */
> > # define __no_kcsan __no_sanitize_thread __disable_sanitizer_instrumentation
> > -# define __no_sanitize_or_inline __no_kcsan notrace __maybe_unused
> > +# define __no_sanitize_or_inline __no_kcsan __notrace_inline __maybe_unused
>
> Ditto.
I'll just keep the notrace on these.
>
> > #else
> > # define __no_kcsan
> > #endif
> > diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
> > index abe5c583bd59..b66ab0e6ce19 100644
> > --- a/kernel/trace/Kconfig
> > +++ b/kernel/trace/Kconfig
> > @@ -106,6 +106,13 @@ config HAVE_BUILDTIME_MCOUNT_SORT
> > An architecture selects this if it sorts the mcount_loc section
> > at build time.
> >
> > +config ARCH_CAN_TRACE_INLINE
> > + bool
> > + help
> > + It is safe for an architecture to trace any function marked
>
> Spaces instead of tab.
Bah, I noticed that my emacs is doing this on other configs I just added.
It adds spaces for the first entry, then tabs for the rest.
>
> > + as inline (not __always_inline) that the compiler decides to
>
> and this one has a tab.
>
> > + not inline.
> > +
> > config BUILDTIME_MCOUNT_SORT
> > bool
> > default y
Thanks for the review!
-- Steve
prev parent reply other threads:[~2023-06-13 15:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 21:44 [PATCH v2] ftrace: Allow inline functions not inlined to be traced Steven Rostedt
2023-06-12 9:56 ` Mark Rutland
2023-06-12 13:54 ` Masami Hiramatsu
2023-06-12 15:09 ` Thomas Gleixner
2023-06-13 15:40 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230613114049.096a8844@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=jpoimboe@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=ndesaulniers@google.com \
--cc=ojeda@kernel.org \
--cc=peterz@infradead.org \
--cc=song@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).