LKML Archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] USB (dwc3-glue) support for Google Tensor gs101
@ 2024-04-23 20:19 André Draszik
  2024-04-23 20:19 ` [PATCH 1/2] dt-bindings: usb: samsung,exynos-dwc3: add gs101 compatible André Draszik
  2024-04-23 20:19 ` [PATCH 2/2] usb: dwc3: exynos: add support for Google Tensor gs101 André Draszik
  0 siblings, 2 replies; 9+ messages in thread
From: André Draszik @ 2024-04-23 20:19 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Alim Akhtar, Peter Griffin, Thinh Nguyen
  Cc: Krzysztof Kozlowski, Tudor Ambarus, Will McVicker, Roy Luo,
	kernel-team, linux-usb, devicetree, linux-arm-kernel,
	linux-samsung-soc, linux-kernel, André Draszik

The Google Tensor gs101 SoC embeds a DWC3 USB 3.1 DRD controller.

This patch series enables the existing dwc3-exynos glue layer to work on
this SoC.

Signed-off-by: André Draszik <andre.draszik@linaro.org>
---
André Draszik (2):
      dt-bindings: usb: samsung,exynos-dwc3: add gs101 compatible
      usb: dwc3: exynos: add support for Google Tensor gs101

 .../devicetree/bindings/usb/samsung,exynos-dwc3.yaml   | 18 ++++++++++++++++++
 drivers/usb/dwc3/dwc3-exynos.c                         |  9 +++++++++
 2 files changed, 27 insertions(+)
---
base-commit: a59668a9397e7245b26e9be85d23f242ff757ae8
change-id: 20240423-usb-dwc3-gs101-1f5864f06ca9

Best regards,
-- 
André Draszik <andre.draszik@linaro.org>


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH 1/2] dt-bindings: usb: samsung,exynos-dwc3: add gs101 compatible
  2024-04-23 20:19 [PATCH 0/2] USB (dwc3-glue) support for Google Tensor gs101 André Draszik
@ 2024-04-23 20:19 ` André Draszik
  2024-04-24 19:46   ` Rob Herring
                     ` (2 more replies)
  2024-04-23 20:19 ` [PATCH 2/2] usb: dwc3: exynos: add support for Google Tensor gs101 André Draszik
  1 sibling, 3 replies; 9+ messages in thread
From: André Draszik @ 2024-04-23 20:19 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Alim Akhtar, Peter Griffin, Thinh Nguyen
  Cc: Krzysztof Kozlowski, Tudor Ambarus, Will McVicker, Roy Luo,
	kernel-team, linux-usb, devicetree, linux-arm-kernel,
	linux-samsung-soc, linux-kernel, André Draszik

The Exynos-based Google Tensor gs101 SoC has a DWC3 compatible USB
controller and can reuse the existing Exynos glue. Update the dt schema
to include the google,gs101-dwusb3 compatible for it.

Signed-off-by: André Draszik <andre.draszik@linaro.org>
---
 .../devicetree/bindings/usb/samsung,exynos-dwc3.yaml   | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml b/Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml
index 1ade99e85ba8..2b3430cebe99 100644
--- a/Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml
+++ b/Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml
@@ -12,6 +12,7 @@ maintainers:
 properties:
   compatible:
     enum:
+      - google,gs101-dwusb3
       - samsung,exynos5250-dwusb3
       - samsung,exynos5433-dwusb3
       - samsung,exynos7-dwusb3
@@ -55,6 +56,23 @@ required:
   - vdd33-supply
 
 allOf:
+  - if:
+      properties:
+        compatible:
+          contains:
+            const: google,gs101-dwusb3
+    then:
+      properties:
+        clocks:
+          minItems: 4
+          maxItems: 4
+        clock-names:
+          items:
+            - const: bus_early
+            - const: susp_clk
+            - const: link_aclk
+            - const: link_pclk
+
   - if:
       properties:
         compatible:

-- 
2.44.0.769.g3c40516874-goog


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 2/2] usb: dwc3: exynos: add support for Google Tensor gs101
  2024-04-23 20:19 [PATCH 0/2] USB (dwc3-glue) support for Google Tensor gs101 André Draszik
  2024-04-23 20:19 ` [PATCH 1/2] dt-bindings: usb: samsung,exynos-dwc3: add gs101 compatible André Draszik
@ 2024-04-23 20:19 ` André Draszik
  2024-04-24 22:43   ` Thinh Nguyen
                     ` (2 more replies)
  1 sibling, 3 replies; 9+ messages in thread
From: André Draszik @ 2024-04-23 20:19 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Alim Akhtar, Peter Griffin, Thinh Nguyen
  Cc: Krzysztof Kozlowski, Tudor Ambarus, Will McVicker, Roy Luo,
	kernel-team, linux-usb, devicetree, linux-arm-kernel,
	linux-samsung-soc, linux-kernel, André Draszik

The Exynos-based Google Tensor gs101 SoC has a DWC3 compatible USB
controller and can reuse the existing Exynos glue. Add the
google,gs101-dwusb3 compatible and associated driver data. Four clocks
are required for USB for this SoC:
    * bus clock
    * suspend clock
    * Link interface AXI clock
    * Link interface APB clock

Signed-off-by: André Draszik <andre.draszik@linaro.org>
---
 drivers/usb/dwc3/dwc3-exynos.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/usb/dwc3/dwc3-exynos.c b/drivers/usb/dwc3/dwc3-exynos.c
index 3427522a7c6a..9a6e988d165a 100644
--- a/drivers/usb/dwc3/dwc3-exynos.c
+++ b/drivers/usb/dwc3/dwc3-exynos.c
@@ -169,6 +169,12 @@ static const struct dwc3_exynos_driverdata exynos850_drvdata = {
 	.suspend_clk_idx = -1,
 };
 
+static const struct dwc3_exynos_driverdata gs101_drvdata = {
+	.clk_names = { "bus_early", "susp_clk", "link_aclk", "link_pclk" },
+	.num_clks = 4,
+	.suspend_clk_idx = 1,
+};
+
 static const struct of_device_id exynos_dwc3_match[] = {
 	{
 		.compatible = "samsung,exynos5250-dwusb3",
@@ -182,6 +188,9 @@ static const struct of_device_id exynos_dwc3_match[] = {
 	}, {
 		.compatible = "samsung,exynos850-dwusb3",
 		.data = &exynos850_drvdata,
+	}, {
+		.compatible = "google,gs101-dwusb3",
+		.data = &gs101_drvdata,
 	}, {
 	}
 };

-- 
2.44.0.769.g3c40516874-goog


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH 1/2] dt-bindings: usb: samsung,exynos-dwc3: add gs101 compatible
  2024-04-23 20:19 ` [PATCH 1/2] dt-bindings: usb: samsung,exynos-dwc3: add gs101 compatible André Draszik
@ 2024-04-24 19:46   ` Rob Herring
  2024-04-25  8:50   ` Krzysztof Kozlowski
  2024-04-25 10:20   ` Peter Griffin
  2 siblings, 0 replies; 9+ messages in thread
From: Rob Herring @ 2024-04-24 19:46 UTC (permalink / raw)
  To: André Draszik
  Cc: linux-samsung-soc, kernel-team, Tudor Ambarus, linux-kernel,
	Will McVicker, Krzysztof Kozlowski, devicetree, Peter Griffin,
	linux-arm-kernel, Thinh Nguyen, Roy Luo, linux-usb, Conor Dooley,
	Krzysztof Kozlowski, Greg Kroah-Hartman, Alim Akhtar


On Tue, 23 Apr 2024 21:19:45 +0100, André Draszik wrote:
> The Exynos-based Google Tensor gs101 SoC has a DWC3 compatible USB
> controller and can reuse the existing Exynos glue. Update the dt schema
> to include the google,gs101-dwusb3 compatible for it.
> 
> Signed-off-by: André Draszik <andre.draszik@linaro.org>
> ---
>  .../devicetree/bindings/usb/samsung,exynos-dwc3.yaml   | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 2/2] usb: dwc3: exynos: add support for Google Tensor gs101
  2024-04-23 20:19 ` [PATCH 2/2] usb: dwc3: exynos: add support for Google Tensor gs101 André Draszik
@ 2024-04-24 22:43   ` Thinh Nguyen
  2024-04-25  8:50   ` Krzysztof Kozlowski
  2024-04-25 10:17   ` Peter Griffin
  2 siblings, 0 replies; 9+ messages in thread
From: Thinh Nguyen @ 2024-04-24 22:43 UTC (permalink / raw)
  To: André Draszik
  Cc: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Alim Akhtar, Peter Griffin, Thinh Nguyen,
	Krzysztof Kozlowski, Tudor Ambarus, Will McVicker, Roy Luo,
	kernel-team@android.com, linux-usb@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org

On Tue, Apr 23, 2024, André Draszik wrote:
> The Exynos-based Google Tensor gs101 SoC has a DWC3 compatible USB
> controller and can reuse the existing Exynos glue. Add the
> google,gs101-dwusb3 compatible and associated driver data. Four clocks
> are required for USB for this SoC:
>     * bus clock
>     * suspend clock
>     * Link interface AXI clock
>     * Link interface APB clock
> 
> Signed-off-by: André Draszik <andre.draszik@linaro.org>
> ---
>  drivers/usb/dwc3/dwc3-exynos.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/usb/dwc3/dwc3-exynos.c b/drivers/usb/dwc3/dwc3-exynos.c
> index 3427522a7c6a..9a6e988d165a 100644
> --- a/drivers/usb/dwc3/dwc3-exynos.c
> +++ b/drivers/usb/dwc3/dwc3-exynos.c
> @@ -169,6 +169,12 @@ static const struct dwc3_exynos_driverdata exynos850_drvdata = {
>  	.suspend_clk_idx = -1,
>  };
>  
> +static const struct dwc3_exynos_driverdata gs101_drvdata = {
> +	.clk_names = { "bus_early", "susp_clk", "link_aclk", "link_pclk" },
> +	.num_clks = 4,
> +	.suspend_clk_idx = 1,
> +};
> +
>  static const struct of_device_id exynos_dwc3_match[] = {
>  	{
>  		.compatible = "samsung,exynos5250-dwusb3",
> @@ -182,6 +188,9 @@ static const struct of_device_id exynos_dwc3_match[] = {
>  	}, {
>  		.compatible = "samsung,exynos850-dwusb3",
>  		.data = &exynos850_drvdata,
> +	}, {
> +		.compatible = "google,gs101-dwusb3",
> +		.data = &gs101_drvdata,
>  	}, {
>  	}
>  };
> 
> -- 
> 2.44.0.769.g3c40516874-goog
> 

Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>

Thanks,
Thinh

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 2/2] usb: dwc3: exynos: add support for Google Tensor gs101
  2024-04-23 20:19 ` [PATCH 2/2] usb: dwc3: exynos: add support for Google Tensor gs101 André Draszik
  2024-04-24 22:43   ` Thinh Nguyen
@ 2024-04-25  8:50   ` Krzysztof Kozlowski
  2024-04-25 10:17   ` Peter Griffin
  2 siblings, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2024-04-25  8:50 UTC (permalink / raw)
  To: André Draszik, Greg Kroah-Hartman, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Alim Akhtar, Peter Griffin,
	Thinh Nguyen
  Cc: Tudor Ambarus, Will McVicker, Roy Luo, kernel-team, linux-usb,
	devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel

On 23/04/2024 22:19, André Draszik wrote:
> The Exynos-based Google Tensor gs101 SoC has a DWC3 compatible USB
> controller and can reuse the existing Exynos glue. Add the
> google,gs101-dwusb3 compatible and associated driver data. Four clocks
> are required for USB for this SoC:
>     * bus clock
>     * suspend clock
>     * Link interface AXI clock
>     * Link interface APB clock
> 
> Signed-off-by: André Draszik <andre.draszik@linaro.org>
> ---
>  drivers/usb/dwc3/dwc3-exynos.c | 9 +++++++++

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 1/2] dt-bindings: usb: samsung,exynos-dwc3: add gs101 compatible
  2024-04-23 20:19 ` [PATCH 1/2] dt-bindings: usb: samsung,exynos-dwc3: add gs101 compatible André Draszik
  2024-04-24 19:46   ` Rob Herring
@ 2024-04-25  8:50   ` Krzysztof Kozlowski
  2024-04-25 10:20   ` Peter Griffin
  2 siblings, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2024-04-25  8:50 UTC (permalink / raw)
  To: André Draszik, Greg Kroah-Hartman, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Alim Akhtar, Peter Griffin,
	Thinh Nguyen
  Cc: Tudor Ambarus, Will McVicker, Roy Luo, kernel-team, linux-usb,
	devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel

On 23/04/2024 22:19, André Draszik wrote:
> The Exynos-based Google Tensor gs101 SoC has a DWC3 compatible USB
> controller and can reuse the existing Exynos glue. Update the dt schema
> to include the google,gs101-dwusb3 compatible for it.
> 
> Signed-off-by: André Draszik <andre.draszik@linaro.org>
> ---
>  .../devicetree/bindings/usb/samsung,exynos-dwc3.yaml   | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 2/2] usb: dwc3: exynos: add support for Google Tensor gs101
  2024-04-23 20:19 ` [PATCH 2/2] usb: dwc3: exynos: add support for Google Tensor gs101 André Draszik
  2024-04-24 22:43   ` Thinh Nguyen
  2024-04-25  8:50   ` Krzysztof Kozlowski
@ 2024-04-25 10:17   ` Peter Griffin
  2 siblings, 0 replies; 9+ messages in thread
From: Peter Griffin @ 2024-04-25 10:17 UTC (permalink / raw)
  To: André Draszik
  Cc: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Alim Akhtar, Thinh Nguyen, Krzysztof Kozlowski,
	Tudor Ambarus, Will McVicker, Roy Luo, kernel-team, linux-usb,
	devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel

On Tue, 23 Apr 2024 at 21:19, André Draszik <andre.draszik@linaro.org> wrote:
>
> The Exynos-based Google Tensor gs101 SoC has a DWC3 compatible USB
> controller and can reuse the existing Exynos glue. Add the
> google,gs101-dwusb3 compatible and associated driver data. Four clocks
> are required for USB for this SoC:
>     * bus clock
>     * suspend clock
>     * Link interface AXI clock
>     * Link interface APB clock
>
> Signed-off-by: André Draszik <andre.draszik@linaro.org>
> ---

Reviewed-by:  Peter Griffin <peter.griffin@linaro.org>

regards,

Peter

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 1/2] dt-bindings: usb: samsung,exynos-dwc3: add gs101 compatible
  2024-04-23 20:19 ` [PATCH 1/2] dt-bindings: usb: samsung,exynos-dwc3: add gs101 compatible André Draszik
  2024-04-24 19:46   ` Rob Herring
  2024-04-25  8:50   ` Krzysztof Kozlowski
@ 2024-04-25 10:20   ` Peter Griffin
  2 siblings, 0 replies; 9+ messages in thread
From: Peter Griffin @ 2024-04-25 10:20 UTC (permalink / raw)
  To: André Draszik
  Cc: Greg Kroah-Hartman, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Alim Akhtar, Thinh Nguyen, Krzysztof Kozlowski,
	Tudor Ambarus, Will McVicker, Roy Luo, kernel-team, linux-usb,
	devicetree, linux-arm-kernel, linux-samsung-soc, linux-kernel

On Tue, 23 Apr 2024 at 21:19, André Draszik <andre.draszik@linaro.org> wrote:
>
> The Exynos-based Google Tensor gs101 SoC has a DWC3 compatible USB
> controller and can reuse the existing Exynos glue. Update the dt schema
> to include the google,gs101-dwusb3 compatible for it.
>
> Signed-off-by: André Draszik <andre.draszik@linaro.org>
> ---

Reviewed-by:  Peter Griffin <peter.griffin@linaro.org>

regards,

Peter

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2024-04-25 10:20 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-23 20:19 [PATCH 0/2] USB (dwc3-glue) support for Google Tensor gs101 André Draszik
2024-04-23 20:19 ` [PATCH 1/2] dt-bindings: usb: samsung,exynos-dwc3: add gs101 compatible André Draszik
2024-04-24 19:46   ` Rob Herring
2024-04-25  8:50   ` Krzysztof Kozlowski
2024-04-25 10:20   ` Peter Griffin
2024-04-23 20:19 ` [PATCH 2/2] usb: dwc3: exynos: add support for Google Tensor gs101 André Draszik
2024-04-24 22:43   ` Thinh Nguyen
2024-04-25  8:50   ` Krzysztof Kozlowski
2024-04-25 10:17   ` Peter Griffin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).