* [PATCH v3] cxl: Fix use of phys_to_target_node() for x86
@ 2024-04-24 15:47 Robert Richter
2024-04-24 23:11 ` Davidlohr Bueso
0 siblings, 1 reply; 2+ messages in thread
From: Robert Richter @ 2024-04-24 15:47 UTC (permalink / raw)
To: Davidlohr Bueso, Jonathan Cameron, Dave Jiang, Alison Schofield,
Vishal Verma, Ira Weiny, Dan Williams
Cc: Robert Richter, linux-cxl, linux-kernel
The CXL driver uses both functions phys_to_target_node() and
memory_add_physaddr_to_nid(). The x86 architecture relies on the
NUMA_KEEP_MEMINFO kernel option enabled for both functions to work
correct. Update Kconfig to make sure the option is always enabled for
the driver.
Suggested-by: Dan Williams <dan.j.williams@intel.com>
Link: http://lore.kernel.org/r/65f8b191c0422_aa222941b@dwillia2-mobl3.amr.corp.intel.com.notmuch
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Robert Richter <rrichter@amd.com>
---
V3: updated SOB chain
---
drivers/cxl/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/cxl/Kconfig b/drivers/cxl/Kconfig
index 67998dbd1d46..6140b3529a29 100644
--- a/drivers/cxl/Kconfig
+++ b/drivers/cxl/Kconfig
@@ -6,6 +6,7 @@ menuconfig CXL_BUS
select FW_UPLOAD
select PCI_DOE
select FIRMWARE_TABLE
+ select NUMA_KEEP_MEMINFO if (NUMA && X86)
help
CXL is a bus that is electrically compatible with PCI Express, but
layers three protocols on that signalling (CXL.io, CXL.cache, and
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3] cxl: Fix use of phys_to_target_node() for x86
2024-04-24 15:47 [PATCH v3] cxl: Fix use of phys_to_target_node() for x86 Robert Richter
@ 2024-04-24 23:11 ` Davidlohr Bueso
0 siblings, 0 replies; 2+ messages in thread
From: Davidlohr Bueso @ 2024-04-24 23:11 UTC (permalink / raw)
To: Robert Richter
Cc: Jonathan Cameron, Dave Jiang, Alison Schofield, Vishal Verma,
Ira Weiny, Dan Williams, linux-cxl, linux-kernel
On Wed, 24 Apr 2024, Robert Richter wrote:
>The CXL driver uses both functions phys_to_target_node() and
>memory_add_physaddr_to_nid(). The x86 architecture relies on the
>NUMA_KEEP_MEMINFO kernel option enabled for both functions to work
>correct. Update Kconfig to make sure the option is always enabled for
>the driver.
>
>Suggested-by: Dan Williams <dan.j.williams@intel.com>
>Link: http://lore.kernel.org/r/65f8b191c0422_aa222941b@dwillia2-mobl3.amr.corp.intel.com.notmuch
>Reviewed-by: Ira Weiny <ira.weiny@intel.com>
>Reviewed-by: Dan Williams <dan.j.williams@intel.com>
>Signed-off-by: Robert Richter <rrichter@amd.com>
Reviewed-by: Davidlohr Bueso <dave@stgolabs.net>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-04-24 23:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-24 15:47 [PATCH v3] cxl: Fix use of phys_to_target_node() for x86 Robert Richter
2024-04-24 23:11 ` Davidlohr Bueso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).