* [PATCH] cpufreq: amd-pstate: Set default governor to schedutil
@ 2023-06-08 9:53 Mario Limonciello
2023-06-09 21:42 ` Leo Li
2023-06-10 10:54 ` Huang Rui
0 siblings, 2 replies; 4+ messages in thread
From: Mario Limonciello @ 2023-06-08 9:53 UTC (permalink / raw)
To: rafael
Cc: linux-pm, linux-kernel, perry.yuan, Ray.Huang, Wyes.Karny,
gautham.shenoy, Mario Limonciello, Sun Peng Li
The Kconfig currently defaults the governor to schedutil on x86_64
only when intel-pstate and SMP have been selected.
If the kernel is built only with amd-pstate, the default governor
should also be schedutil.
Cc: Sun Peng (Leo) Li <sunpeng.li@amd.com>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
drivers/cpufreq/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig
index 2c839bd2b051..a1c51abddbc5 100644
--- a/drivers/cpufreq/Kconfig
+++ b/drivers/cpufreq/Kconfig
@@ -38,7 +38,7 @@ choice
prompt "Default CPUFreq governor"
default CPU_FREQ_DEFAULT_GOV_USERSPACE if ARM_SA1110_CPUFREQ
default CPU_FREQ_DEFAULT_GOV_SCHEDUTIL if ARM64 || ARM
- default CPU_FREQ_DEFAULT_GOV_SCHEDUTIL if X86_INTEL_PSTATE && SMP
+ default CPU_FREQ_DEFAULT_GOV_SCHEDUTIL if (X86_INTEL_PSTATE || X86_AMD_PSTATE) && SMP
default CPU_FREQ_DEFAULT_GOV_PERFORMANCE
help
This option sets which CPUFreq governor shall be loaded at
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] cpufreq: amd-pstate: Set default governor to schedutil
2023-06-08 9:53 [PATCH] cpufreq: amd-pstate: Set default governor to schedutil Mario Limonciello
@ 2023-06-09 21:42 ` Leo Li
2023-06-10 10:54 ` Huang Rui
1 sibling, 0 replies; 4+ messages in thread
From: Leo Li @ 2023-06-09 21:42 UTC (permalink / raw)
To: Mario Limonciello, rafael
Cc: linux-pm, linux-kernel, perry.yuan, Ray.Huang, Wyes.Karny,
gautham.shenoy
On 6/8/23 05:53, Mario Limonciello wrote:
> The Kconfig currently defaults the governor to schedutil on x86_64
> only when intel-pstate and SMP have been selected.
>
> If the kernel is built only with amd-pstate, the default governor
> should also be schedutil.
>
> Cc: Sun Peng (Leo) Li <sunpeng.li@amd.com>
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Reviewed-by: Leo Li <sunpeng.li@amd.com>
Thanks!
> ---
> drivers/cpufreq/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig
> index 2c839bd2b051..a1c51abddbc5 100644
> --- a/drivers/cpufreq/Kconfig
> +++ b/drivers/cpufreq/Kconfig
> @@ -38,7 +38,7 @@ choice
> prompt "Default CPUFreq governor"
> default CPU_FREQ_DEFAULT_GOV_USERSPACE if ARM_SA1110_CPUFREQ
> default CPU_FREQ_DEFAULT_GOV_SCHEDUTIL if ARM64 || ARM
> - default CPU_FREQ_DEFAULT_GOV_SCHEDUTIL if X86_INTEL_PSTATE && SMP
> + default CPU_FREQ_DEFAULT_GOV_SCHEDUTIL if (X86_INTEL_PSTATE || X86_AMD_PSTATE) && SMP
> default CPU_FREQ_DEFAULT_GOV_PERFORMANCE
> help
> This option sets which CPUFreq governor shall be loaded at
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] cpufreq: amd-pstate: Set default governor to schedutil
2023-06-08 9:53 [PATCH] cpufreq: amd-pstate: Set default governor to schedutil Mario Limonciello
2023-06-09 21:42 ` Leo Li
@ 2023-06-10 10:54 ` Huang Rui
2023-06-12 2:43 ` Yuan, Perry
1 sibling, 1 reply; 4+ messages in thread
From: Huang Rui @ 2023-06-10 10:54 UTC (permalink / raw)
To: Limonciello, Mario
Cc: rafael@kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, Yuan, Perry, Karny, Wyes,
Shenoy, Gautham Ranjal, Li, Sun peng (Leo)
On Thu, Jun 08, 2023 at 05:53:58PM +0800, Limonciello, Mario wrote:
> The Kconfig currently defaults the governor to schedutil on x86_64
> only when intel-pstate and SMP have been selected.
>
> If the kernel is built only with amd-pstate, the default governor
> should also be schedutil.
>
> Cc: Sun Peng (Leo) Li <sunpeng.li@amd.com>
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Acked-by: Huang Rui <ray.huang@amd.com>
> ---
> drivers/cpufreq/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig
> index 2c839bd2b051..a1c51abddbc5 100644
> --- a/drivers/cpufreq/Kconfig
> +++ b/drivers/cpufreq/Kconfig
> @@ -38,7 +38,7 @@ choice
> prompt "Default CPUFreq governor"
> default CPU_FREQ_DEFAULT_GOV_USERSPACE if ARM_SA1110_CPUFREQ
> default CPU_FREQ_DEFAULT_GOV_SCHEDUTIL if ARM64 || ARM
> - default CPU_FREQ_DEFAULT_GOV_SCHEDUTIL if X86_INTEL_PSTATE && SMP
> + default CPU_FREQ_DEFAULT_GOV_SCHEDUTIL if (X86_INTEL_PSTATE || X86_AMD_PSTATE) && SMP
> default CPU_FREQ_DEFAULT_GOV_PERFORMANCE
> help
> This option sets which CPUFreq governor shall be loaded at
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] cpufreq: amd-pstate: Set default governor to schedutil
2023-06-10 10:54 ` Huang Rui
@ 2023-06-12 2:43 ` Yuan, Perry
0 siblings, 0 replies; 4+ messages in thread
From: Yuan, Perry @ 2023-06-12 2:43 UTC (permalink / raw)
To: Huang, Ray, Limonciello, Mario
Cc: rafael@kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, Karny, Wyes, Shenoy, Gautham Ranjal,
Li, Sun peng (Leo), Yuan, Perry, Huang, Shimmer,
Meng, Li (Jassmine)
[AMD Official Use Only - General]
> -----Original Message-----
> From: Huang, Ray <Ray.Huang@amd.com>
> Sent: Saturday, June 10, 2023 6:55 PM
> To: Limonciello, Mario <Mario.Limonciello@amd.com>
> Cc: rafael@kernel.org; linux-pm@vger.kernel.org; linux-
> kernel@vger.kernel.org; Yuan, Perry <Perry.Yuan@amd.com>; Karny, Wyes
> <Wyes.Karny@amd.com>; Shenoy, Gautham Ranjal
> <gautham.shenoy@amd.com>; Li, Sun peng (Leo) <Sunpeng.Li@amd.com>
> Subject: Re: [PATCH] cpufreq: amd-pstate: Set default governor to schedutil
>
> On Thu, Jun 08, 2023 at 05:53:58PM +0800, Limonciello, Mario wrote:
> > The Kconfig currently defaults the governor to schedutil on x86_64
> > only when intel-pstate and SMP have been selected.
> >
> > If the kernel is built only with amd-pstate, the default governor
> > should also be schedutil.
> >
> > Cc: Sun Peng (Leo) Li <sunpeng.li@amd.com>
> > Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
>
> Acked-by: Huang Rui <ray.huang@amd.com>
>
> > ---
> > drivers/cpufreq/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig index
> > 2c839bd2b051..a1c51abddbc5 100644
> > --- a/drivers/cpufreq/Kconfig
> > +++ b/drivers/cpufreq/Kconfig
> > @@ -38,7 +38,7 @@ choice
> > prompt "Default CPUFreq governor"
> > default CPU_FREQ_DEFAULT_GOV_USERSPACE if
> ARM_SA1110_CPUFREQ
> > default CPU_FREQ_DEFAULT_GOV_SCHEDUTIL if ARM64 || ARM
> > - default CPU_FREQ_DEFAULT_GOV_SCHEDUTIL if X86_INTEL_PSTATE
> && SMP
> > + default CPU_FREQ_DEFAULT_GOV_SCHEDUTIL if
> (X86_INTEL_PSTATE ||
> > +X86_AMD_PSTATE) && SMP
> > default CPU_FREQ_DEFAULT_GOV_PERFORMANCE
> > help
> > This option sets which CPUFreq governor shall be loaded at
> > --
> > 2.34.1
> >
Tested-by: Perry Yuan <Perry.Yuan@amd.com>
Regards.
Perry Yuan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-06-12 2:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-08 9:53 [PATCH] cpufreq: amd-pstate: Set default governor to schedutil Mario Limonciello
2023-06-09 21:42 ` Leo Li
2023-06-10 10:54 ` Huang Rui
2023-06-12 2:43 ` Yuan, Perry
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).