From: Hanjun Guo <guohanjun@huawei.com>
To: Mark Brown <broonie@kernel.org>, qiujiang <qiujiang@huawei.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
<charles.chenxin@huawei.com>, <linuxarm@huawei.com>,
<linux-kernel@vger.kernel.org>, <linux-acpi@vger.kernel.org>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
<linux-spi@vger.kernel.org>
Subject: Re: [RFC PATCH] SPI/ACPI: DesignWare: Add ACPI support for Designware SPI driver
Date: Mon, 15 Feb 2016 16:27:51 +0800 [thread overview]
Message-ID: <56C18C07.2030209@huawei.com> (raw)
In-Reply-To: <20160205110900.GA12311@sirena.org.uk>
On 2016/2/5 19:09, Mark Brown wrote:
> On Fri, Feb 05, 2016 at 03:11:20PM +0800, qiujiang wrote:
>
>> This patch added ACPI support for DesignWare SPI mmio driver. It
>> was based the corresponding DT driver and compatible for this two
>> way. This patch has been tested on Hisilicon D02 board. It relies
>> on the GPIO patchset.
> Intel are heavy users of this driver on their systems which also use
> ACPI. Have you discussed this binding with them? I've copied Andy and
> Jarkko who've worked on the driver recently.
There is no ACPI code in this driver yet, seems "PRP0001" is used to reuse
this driver directly.
[...]
>
>> +static const struct acpi_device_id dw_spi_mmio_acpi_match[] = {
>> + {"HISI0171", 0},
>> + { }
>> +};
>> +MODULE_DEVICE_TABLE(acpi, dw_spi_mmio_acpi_match);
> I really do wish ACPI had some more sensible system for allocating
> device IDs so the tables were a little more legible. :(
Hmm, I agree. but for now, every OEM can request ACPI or PNP ID with specific
prefixes, and they can manage it by themselves, that would flexible for OEM verdors
to develop firmware and driver.
For this driver in particular, if DesignWare provides the ACPI or PNP ID, that would
be great for all OEMs can reuse it.
Thanks
Hanjun
next prev parent reply other threads:[~2016-02-15 8:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-05 7:11 [RFC PATCH] SPI/ACPI: DesignWare: Add ACPI support for Designware SPI driver qiujiang
2016-02-05 11:09 ` Mark Brown
2016-02-14 9:31 ` Jiang Qiu
2016-02-15 17:44 ` Mark Brown
2016-02-15 8:27 ` Hanjun Guo [this message]
2016-02-15 17:45 ` Mark Brown
2016-02-15 18:09 ` One Thousand Gnomes
2016-02-05 15:55 ` Andy Shevchenko
2016-02-05 16:11 ` Mark Brown
2016-02-14 9:47 ` Jiang Qiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C18C07.2030209@huawei.com \
--to=guohanjun@huawei.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=charles.chenxin@huawei.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=qiujiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).