From: Madars Vitolins <m@silodev.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Jason Baron <jbaron@akamai.com>,
torvalds@linux-foundation.org, mtk.manpages@gmail.com,
mingo@kernel.org, peterz@infradead.org, viro@ftp.linux.org.uk,
normalperson@yhbt.net, corbet@lwn.net, luto@amacapital.net,
hagen@jauu.net, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org
Subject: Re: [PATCH] epoll: restrict EPOLLEXCLUSIVE to POLLIN and POLLOUT
Date: Fri, 05 Feb 2016 11:49:47 +0200 [thread overview]
Message-ID: <994cbd84457a4986e03ad0c4369600fa@silodev.com> (raw)
In-Reply-To: <20160204145952.53f536f5d4cdef96844104b7@linux-foundation.org>
Andrew Morton @ 2016-02-05 00:59 rakstīja:
> On Thu, 04 Feb 2016 23:44:05 +0200 Madars Vitolins <m@silodev.com>
> wrote:
>
>> Hi Jason,
>>
>>
>> Just run off the original tests with this patch (eventpoll.c from
>> 4.5-rc2 + patch bellow). Got the same good results, no regression.
>>
>> $ time ./bankcl
>> Account balance is: 1359856158.04 USD
>> Account balance is: 1359856158.04 USD
>> Account balance is: 1359856158.04 USD
>> Account balance is: 1359856158.04 USD
>> Account balance is: 1359856158.04 USD
>> Account balance is: 1359856158.04 USD
>> Account balance is: 1359856158.04 USD
>> Account balance is: 1359856158.04 USD
>> Account balance is: 1359856158.04 USD
>> Account balance is: 101528948.40 USD
>>
>> real 0m41.826s
>> user 0m29.513s
>> sys 0m6.490s
>>
>>
>> Test case:
>> https://mvitolin.wordpress.com/2015/12/05/endurox-testing-epollexclusive-flag/
>>
>> PS,
>>
>> Original cases 0m24.953s vs 0m41.826s now probably is related with my
>> pc
>> setup. As I just now re-run test with original patch, got the same ~41
>> sec.
>>
>> So I am fine with this patch!
>>
>
> Thanks, I shall add your Tested-by:
>
> One thing we're sorely missing is an epoll test suite, in
> tools/testing/selftests. If anyone has anything which we can use to
> kick things off, please hand it over ;)
Not bad idea, probably we need a "tools/testing/selftests/eventpoll"
folder under which we should have test cases for various epoll scenarios
with common "run.sh". In spare time I can try to build a case for
EXCLUSIVE flag (with queues & multiple processes :) ).
Thanks,
Madars
prev parent reply other threads:[~2016-02-05 9:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-04 15:39 [PATCH] epoll: restrict EPOLLEXCLUSIVE to POLLIN and POLLOUT Jason Baron
2016-02-04 21:44 ` Madars Vitolins
2016-02-04 22:59 ` Andrew Morton
2016-02-05 9:49 ` Madars Vitolins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=994cbd84457a4986e03ad0c4369600fa@silodev.com \
--to=m@silodev.com \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=hagen@jauu.net \
--cc=jbaron@akamai.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=normalperson@yhbt.net \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).