From: Doug Anderson <dianders@chromium.org>
To: Cong Yang <yangcong5@huaqin.corp-partner.google.com>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, dmitry.torokhov@gmail.com, jikos@kernel.org,
benjamin.tissoires@redhat.com, hsinyi@google.com,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/2] HID: i2c-hid: elan: Add ili9882t timing
Date: Thu, 8 Jun 2023 06:38:40 -0700 [thread overview]
Message-ID: <CAD=FV=VsmAzxSx9LN5pe6DjMF9C6AJHX5kwZyNG=deUpW1jyRg@mail.gmail.com> (raw)
In-Reply-To: <20230608130147.2835818-3-yangcong5@huaqin.corp-partner.google.com>
Hi,
On Thu, Jun 8, 2023 at 6:02 AM Cong Yang
<yangcong5@huaqin.corp-partner.google.com> wrote:
>
> +static const struct elan_i2c_hid_chip_data ilitek_ili9882t_chip_data = {
> + .post_power_delay_ms = 1,
> + .post_gpio_reset_on_delay_ms = 200,
> + .post_gpio_reset_off_delay_ms = 65,
> .hid_descriptor_address = 0x0001,
> + /* this touchscreen is tightly integrated with the panel and assumes
> + * that the relevant power rails (other than the IO rail) have already
> + * been turned on by the panel driver because we're a panel follower.
> + */
I don't think the above is the right block comment style for this
file. The first "/*" should be on a line on its own.
> + .main_supply_name = "null",
This should actually be NULL without the quotes. ...then you should
change the code not to try to grab the regulator in that case.
prev parent reply other threads:[~2023-06-08 13:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-08 13:01 [PATCH v4 0/2] Add ili9882t bindings and timing Cong Yang
2023-06-08 13:01 ` [PATCH v4 1/2] dt-bindings: HID: i2c-hid: ilitek: Introduce bindings for Ilitek ili9882t Cong Yang
2023-06-08 13:37 ` Doug Anderson
2023-06-09 15:50 ` Krzysztof Kozlowski
2023-06-09 15:56 ` Doug Anderson
2023-06-09 15:59 ` Krzysztof Kozlowski
2023-06-08 13:01 ` [PATCH v4 2/2] HID: i2c-hid: elan: Add ili9882t timing Cong Yang
2023-06-08 13:38 ` Doug Anderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=VsmAzxSx9LN5pe6DjMF9C6AJHX5kwZyNG=deUpW1jyRg@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=benjamin.tissoires@redhat.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=hsinyi@google.com \
--cc=jikos@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=yangcong5@huaqin.corp-partner.google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).