From: Dmitry Safonov <0x7f454c46@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: mingo@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [RFC] trace_irqsoff: remove redundant reset per-CPU buff
Date: Fri, 5 Feb 2016 14:52:53 +0300 [thread overview]
Message-ID: <CAJwJo6a+sgGRCaPQMyYy7o2QtS3BhuAuT=ZbBYYLx77WkbY2Pw@mail.gmail.com> (raw)
In-Reply-To: <20160204214045.1d6c2893@grimm.local.home>
2016-02-05 5:40 GMT+03:00 Steven Rostedt <rostedt@goodmis.org>:
> On Mon, 19 Oct 2015 21:10:26 +0300
> Dmitry Safonov <0x7f454c46@gmail.com> wrote:
>
>> There is no reason to do it twice: from commit b6f11df26fdc28
>> ("trace: Call tracing_reset_online_cpus before tracer->init()")
>> resetting of per-CPU buffers done before tracer->init() call.
>>
>> tracer->init() calls {irqs,preempt,preemptirqs}off_tracer_init() and it
>> calls __irqsoff_tracer_init(), which resets per-CPU ringbuffer second
>> time.
>> It's slowpath, but anyway.
>
> Bah, I said I'd look at this and I did. But never added it to my queue.
> It's not a big deal as this is the slow path but it makes sense. I knew
> there was a patch from you to get but saw the TP_ARGS redefining patch
> and thought that was it.
Thanks, Steve!
Yeah, I know it may take time to get to unimportant patches
that are also mostly cleanups.
Don't worry, please, take a glance when you'll have time on these
small also not important cleanings (I'm fine if you'll drop them all):
https://lkml.org/lkml/2015/11/20/290
https://lkml.org/lkml/2015/11/20/291
https://lkml.org/lkml/2015/10/30/580
>
> I Cc'd myself on this to make sure I see it again.
>
> -- Steve
--
Regards,
Safonov Dmitry.
next prev parent reply other threads:[~2016-02-05 11:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-19 18:10 [RFC] trace_irqsoff: remove redundant reset per-CPU buff Dmitry Safonov
2015-11-03 18:25 ` Dmitry Safonov
2015-11-03 18:37 ` Steven Rostedt
2016-02-05 2:40 ` Steven Rostedt
2016-02-05 11:52 ` Dmitry Safonov [this message]
2016-02-05 14:40 ` Steven Rostedt
2016-02-05 15:04 ` Steven Rostedt
2016-02-05 15:56 ` Dmitry Safonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJwJo6a+sgGRCaPQMyYy7o2QtS3BhuAuT=ZbBYYLx77WkbY2Pw@mail.gmail.com' \
--to=0x7f454c46@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).