* [PATCH v2] tpm: tpm_tis: Narrow the AAEON DMI quirk to UPX-i11 only
@ 2023-05-24 8:58 Peter Ujfalusi
2023-06-09 18:44 ` Jarkko Sakkinen
0 siblings, 1 reply; 2+ messages in thread
From: Peter Ujfalusi @ 2023-05-24 8:58 UTC (permalink / raw)
To: peterhuewe, jarkko
Cc: jgg, linux-integrity, linux-kernel, l.sanfilippo, peter.ujfalusi,
jsnitsel, pmenzel
The original patch which added the quirk would apply to all AAEON machines,
which might or might not be valid.
The issue was discovered on UPX-i11 (Tiger Lake), it is not known if the
i12 (Alder Lake) version is affected.
UP2 (Apollo Lake) does not even have TPM module (no TPM drivers probing
and confirmed by dmidecode).
Let's make the quirk to be applicable for UPX-i11 (UPX-TGL01) only.
Fixes: 95a9359ee22f ("tpm: tpm_tis: Disable interrupts for AEON UPX-i11")
Suggested-by: Jerry Snitselaar <jsnitsel@redhat.com>
Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
---
Hi Jarkko,
Changes since v1:
- Findings from Paul Menzel in the commit message has been addressed
the patch is generated on top of your
git://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git : irq-storm
Regards,
Peter
drivers/char/tpm/tpm_tis.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
index 7db3593941ea..4357d4ba8f9e 100644
--- a/drivers/char/tpm/tpm_tis.c
+++ b/drivers/char/tpm/tpm_tis.c
@@ -143,6 +143,7 @@ static const struct dmi_system_id tpm_tis_dmi_table[] = {
.ident = "UPX-TGL",
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "AAEON"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "UPX-TGL01"),
},
},
{}
--
2.40.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] tpm: tpm_tis: Narrow the AAEON DMI quirk to UPX-i11 only
2023-05-24 8:58 [PATCH v2] tpm: tpm_tis: Narrow the AAEON DMI quirk to UPX-i11 only Peter Ujfalusi
@ 2023-06-09 18:44 ` Jarkko Sakkinen
0 siblings, 0 replies; 2+ messages in thread
From: Jarkko Sakkinen @ 2023-06-09 18:44 UTC (permalink / raw)
To: Peter Ujfalusi, peterhuewe
Cc: jgg, linux-integrity, linux-kernel, l.sanfilippo, jsnitsel,
pmenzel
On Wed May 24, 2023 at 11:58 AM EEST, Peter Ujfalusi wrote:
> The original patch which added the quirk would apply to all AAEON machines,
> which might or might not be valid.
>
> The issue was discovered on UPX-i11 (Tiger Lake), it is not known if the
> i12 (Alder Lake) version is affected.
> UP2 (Apollo Lake) does not even have TPM module (no TPM drivers probing
> and confirmed by dmidecode).
>
> Let's make the quirk to be applicable for UPX-i11 (UPX-TGL01) only.
>
> Fixes: 95a9359ee22f ("tpm: tpm_tis: Disable interrupts for AEON UPX-i11")
> Suggested-by: Jerry Snitselaar <jsnitsel@redhat.com>
> Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
> ---
> Hi Jarkko,
>
> Changes since v1:
> - Findings from Paul Menzel in the commit message has been addressed
>
> the patch is generated on top of your
> git://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git : irq-storm
>
> Regards,
> Peter
>
> drivers/char/tpm/tpm_tis.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
> index 7db3593941ea..4357d4ba8f9e 100644
> --- a/drivers/char/tpm/tpm_tis.c
> +++ b/drivers/char/tpm/tpm_tis.c
> @@ -143,6 +143,7 @@ static const struct dmi_system_id tpm_tis_dmi_table[] = {
> .ident = "UPX-TGL",
> .matches = {
> DMI_MATCH(DMI_SYS_VENDOR, "AAEON"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "UPX-TGL01"),
> },
> },
> {}
> --
> 2.40.1
I had this already applied:
https://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git/commit/?id=20e0e7d7ec975897f40b4ee635266d36f9083856
BR, Jarkko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-06-09 18:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-24 8:58 [PATCH v2] tpm: tpm_tis: Narrow the AAEON DMI quirk to UPX-i11 only Peter Ujfalusi
2023-06-09 18:44 ` Jarkko Sakkinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).