From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: "jim.tsai" <Wei-chin.Tsai@mediatek.com>
Cc: linux-kernel@vger.kernel.org,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
wsd_upstream@mediatek.com, mel.lee@mediatek.com,
ivan.tseng@mediatek.com, linux-arm-kernel@lists.infradead.org,
linux-fsdevel@vger.kernel.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v1 1/1] memory: export symbols for process memory related functions
Date: Fri, 9 Jun 2023 12:20:21 +0100 [thread overview]
Message-ID: <ZIMK9QV5+ce69Shr@shell.armlinux.org.uk> (raw)
In-Reply-To: <20230609110902.13799-1-Wei-chin.Tsai@mediatek.com>
On Fri, Jun 09, 2023 at 07:09:00PM +0800, jim.tsai wrote:
> Export symbols for arch_vma_name and smap_gather_stats
> functions so that we can detect the memory leak issues.
> Besides, we can know which memory type is leaked, too.
This commit description doesn't give enough information. How does
exporting arch_vma_name() help with detecting memory leak issues?
You haven't included any users of these new exports, so the initial
reaction is going to be negative - please include the users of these
new symbols in your patch set.
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next parent reply other threads:[~2023-06-09 11:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230609110902.13799-1-Wei-chin.Tsai@mediatek.com>
2023-06-09 11:20 ` Russell King (Oracle) [this message]
2023-06-09 16:09 ` [PATCH v1 1/1] memory: export symbols for process memory related functions Wei-chin Tsai (蔡維晉)
2023-06-10 0:21 ` Matthew Wilcox
2023-06-12 14:21 ` Wei-chin Tsai (蔡維晉)
2023-06-16 9:24 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIMK9QV5+ce69Shr@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=Wei-chin.Tsai@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=ivan.tseng@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mel.lee@mediatek.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).