From: Matthew Wilcox <willy@infradead.org>
To: "Wei-chin Tsai (蔡維晉)" <Wei-chin.Tsai@mediatek.com>
Cc: "linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Mel Lee (李奇錚)" <Mel.Lee@mediatek.com>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
wsd_upstream <wsd_upstream@mediatek.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"Ivan Tseng (曾志軒)" <ivan.tseng@mediatek.com>,
"angelogioacchino.delregno@collabora.com"
<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH v1 1/1] memory: export symbols for process memory related functions
Date: Sat, 10 Jun 2023 01:21:54 +0100 [thread overview]
Message-ID: <ZIPCIpWPQbVqoI4q@casper.infradead.org> (raw)
In-Reply-To: <5cc76704214673cf03376d9f10f61325b9ed323f.camel@mediatek.com>
On Fri, Jun 09, 2023 at 04:09:01PM +0000, Wei-chin Tsai (蔡維晉) wrote:
> > You haven't included any users of these new exports, so the initial
> > reaction is going to be negative - please include the users of these
> > new symbols in your patch set.
> We use these two export functions from our kernel module to get a
> specific user process's memory information and heap usage. Furthermore,
> we can use such information to detect the memory leak issues.
>
> The example code is as follows:
No. You need to be submitting the code that will use the symbol *at the
same time* as the patch to export the symbol. No example code showing
how it could be used. Because if the user isn't compelling, the patch
to export the symbol won't be applied either.
next prev parent reply other threads:[~2023-06-10 0:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230609110902.13799-1-Wei-chin.Tsai@mediatek.com>
2023-06-09 11:20 ` [PATCH v1 1/1] memory: export symbols for process memory related functions Russell King (Oracle)
2023-06-09 16:09 ` Wei-chin Tsai (蔡維晉)
2023-06-10 0:21 ` Matthew Wilcox [this message]
2023-06-12 14:21 ` Wei-chin Tsai (蔡維晉)
2023-06-16 9:24 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIPCIpWPQbVqoI4q@casper.infradead.org \
--to=willy@infradead.org \
--cc=Mel.Lee@mediatek.com \
--cc=Wei-chin.Tsai@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=ivan.tseng@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=matthias.bgg@gmail.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).