From: Judith Mendez <jm@ti.com>
To: David Lechner <david@lechnology.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
William Breathitt Gray <william.gray@linaro.org>
Cc: <linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-iio@vger.kernel.org>
Subject: Re: [PATCH 5/7] dt-bindings: counter: Update TI eQEP binding
Date: Mon, 22 Apr 2024 17:15:30 -0500 [thread overview]
Message-ID: <a4fcaaad-de8a-4809-9277-ffb63f6227b3@ti.com> (raw)
In-Reply-To: <4cf5f463-dccd-4637-b7ce-e8d8eac044b7@lechnology.com>
On 4/22/24 1:25 PM, David Lechner wrote:
> On 4/18/24 5:14 PM, Judith Mendez wrote:
>> Update eQEP binding for TI K3 devices.
>
>
> It would make more sense to have this patch first in the series
> before the dts changes.
Got it.
>
>>
>> Signed-off-by: Judith Mendez <jm@ti.com>
>> ---
>> Documentation/devicetree/bindings/counter/ti-eqep.yaml | 10 +++++++---
>> 1 file changed, 7 insertions(+), 3 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/counter/ti-eqep.yaml b/Documentation/devicetree/bindings/counter/ti-eqep.yaml
>> index 85f1ff83afe72..11755074c8a91 100644
>> --- a/Documentation/devicetree/bindings/counter/ti-eqep.yaml
>> +++ b/Documentation/devicetree/bindings/counter/ti-eqep.yaml
>> @@ -14,19 +14,23 @@ properties:
>> const: ti,am3352-eqep
>>
>
> As Krzysztof hinted, it sounds like we need to add new compatibles
> here and have some -if: statements to account for the differences
> in SoCs rather than making the bindings less strict.
Yes, I see this is the correct action. Thanks.
>
>> reg:
>> - maxItems: 1
>> + minItems: 1
>> + maxItems: 2
>>
>> interrupts:
>> description: The eQEP event interrupt
>> maxItems: 1
>>
>> clocks:
>> - description: The clock that determines the SYSCLKOUT rate for the eQEP
>> + description: The clock that determines the clock rate for the eQEP
>> peripheral.
>> maxItems: 1
>>
>> clock-names:
>> - const: sysclkout
>> + maxItems: 1
>
> In hindsight, this is not the best name. Since we only have one clock
> we don't really need the name anyway, so for the new compatibles, we
> could set clock-names: false.
Ok, will add this to new compatible.
>
>> +
>> + power-domains:
>> + maxItems: 1
>>
>> required:
>> - compatible
>
>
> I see that the CFG0 syscon register on AM62x has some control knobs for
> the EQEP so it would be good to add this to the bindings now too to try
> to make the bindings as complete as possible. (I didn't look at other
> chips so the same may apply to others as well.)
Got it (:
~ Judith
>
next prev parent reply other threads:[~2024-04-22 22:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 22:14 [PATCH 0/7] Enable eQEP DT support for Sitara K3 platforms Judith Mendez
2024-04-18 22:14 ` [PATCH 1/7] arm64: dts: ti: k3-am62-main: Add eQEP nodes Judith Mendez
2024-04-19 13:56 ` Krzysztof Kozlowski
2024-04-22 22:07 ` Judith Mendez
2024-04-18 22:14 ` [PATCH 2/7] arm64: dts: ti: k3-am62a-main: " Judith Mendez
2024-04-18 22:14 ` [PATCH 3/7] arm64: dts: ti: k3-am62p-main: " Judith Mendez
2024-04-18 22:14 ` [PATCH 4/7] arm64: dts: ti: k3-am64-main: " Judith Mendez
2024-04-18 22:14 ` [PATCH 5/7] dt-bindings: counter: Update TI eQEP binding Judith Mendez
2024-04-19 13:55 ` Krzysztof Kozlowski
2024-04-22 22:11 ` Judith Mendez
2024-04-23 9:54 ` Krzysztof Kozlowski
2024-04-22 18:25 ` David Lechner
2024-04-22 22:15 ` Judith Mendez [this message]
2024-04-18 22:14 ` [PATCH 6/7] counter: ti-eqep: Allow eQEP driver to be built for K3 devices Judith Mendez
2024-04-18 22:14 ` [PATCH 7/7] arm64: defconfig: Enable TI eQEP Driver Judith Mendez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4fcaaad-de8a-4809-9277-ffb63f6227b3@ti.com \
--to=jm@ti.com \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=david@lechnology.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=will@kernel.org \
--cc=william.gray@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).