From: Jakub Kicinski <kuba@kernel.org>
To: Jitendra Vegiraju <jitendra.vegiraju@broadcom.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH, net-next, 2/2] net: stmmac: PCI driver for BCM8958X SoC
Date: Fri, 10 May 2024 18:35:42 -0700 [thread overview]
Message-ID: <20240510183542.3165bc96@kernel.org> (raw)
In-Reply-To: <20240510000331.154486-3-jitendra.vegiraju@broadcom.com>
On Thu, 9 May 2024 17:03:31 -0700 Jitendra Vegiraju wrote:
> + * dwxgmac_brcm_pci_probe
> + *
> + * @pdev: pci device pointer
> + * @id: pointer to table of device id/id's.
the kdoc format for probe and remove is not completely correct
(try ./scripts/kernel-doc -Wall -none $filename)
I'd just remove it, it doesn't explain anything of importance.
--
pw-bot: cr
next prev parent reply other threads:[~2024-05-11 1:35 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 0:03 [PATCH, net-next, 0/2] net: stmmac: support for BCM8958x SoC Jitendra Vegiraju
2024-05-10 0:03 ` [PATCH, net-next, 1/2] net: stmmac: Export dma_ops for reuse in glue drivers Jitendra Vegiraju
2024-05-10 0:03 ` [PATCH, net-next, 2/2] net: stmmac: PCI driver for BCM8958X SoC Jitendra Vegiraju
2024-05-11 1:35 ` Jakub Kicinski [this message]
2024-05-11 1:59 ` [PATCH v2, " Jitendra Vegiraju
2024-05-11 2:08 ` Jakub Kicinski
2024-05-13 16:47 ` Jitendra Vegiraju
2024-05-11 16:16 ` Andrew Lunn
2024-05-11 17:12 ` Russell King (Oracle)
2024-05-11 17:19 ` Andrew Lunn
2024-05-11 19:35 ` Russell King (Oracle)
2024-05-11 17:50 ` Andrew Lunn
2024-05-11 19:36 ` Russell King (Oracle)
2024-05-13 17:32 ` Jitendra Vegiraju
2024-05-13 18:07 ` Andrew Lunn
2024-05-14 8:19 ` Russell King (Oracle)
2024-05-14 16:18 ` Florian Fainelli
2024-05-11 19:34 ` Russell King (Oracle)
2024-05-13 17:38 ` Jitendra Vegiraju
2024-05-13 17:41 ` Russell King (Oracle)
2024-05-13 19:52 ` Andrew Lunn
2024-05-12 8:35 ` Simon Horman
2024-05-17 23:50 ` [PATCH, " kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240510183542.3165bc96@kernel.org \
--to=kuba@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jitendra.vegiraju@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).