From: Florian Fainelli <florian.fainelli@broadcom.com>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>,
Jitendra Vegiraju <jitendra.vegiraju@broadcom.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com,
bcm-kernel-feedback-list@broadcom.com,
alexandre.torgue@foss.st.com, joabreu@synopsys.com,
mcoquelin.stm32@gmail.com, richardcochran@gmail.com,
linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2, net-next, 2/2] net: stmmac: PCI driver for BCM8958X SoC
Date: Tue, 14 May 2024 09:18:57 -0700 [thread overview]
Message-ID: <2859e842-fe0b-4daf-b926-fa7db535b968@broadcom.com> (raw)
In-Reply-To: <ZkMeoB05cV/pK89B@shell.armlinux.org.uk>
[-- Attachment #1: Type: text/plain, Size: 1416 bytes --]
On 5/14/24 01:19, Russell King (Oracle) wrote:
> On Mon, May 13, 2024 at 10:32:19AM -0700, Jitendra Vegiraju wrote:
>> +==================================================+
>> Since the legacy fixed link cannot support 10G, we are initializing to
>> fixed speed 1G.
>
> Or to put it a different way... "I can't represent my hardware so I'm
> going to hack around with the kernel in a way that lies to the kernel
> about what the hardware is doing but it'll work for me!"
>
> Sorry, but no, this isn't some hacky github project, this is the kernel
> where we engineer proper solutions.
You are painting a picture of someone who is a first time contributor to
Linux, there should not be any ill intentions at that point, just a
knowledge gap that needs to be filled.
When I reviewed the patches internally the topic of fixed-link versus
using PHYLINK did come up, and I should have dug a lot more and asked
more questions to understand the full picture. Since the bulk of the
changes had to do with hooking up a different DMA engine and
configuration, I focused on that part and let the PHY connectivity
aspect slip.
I will work with Jitendra to bring him up to speed with the software
nodes, the work that Herve is doing on supporting OF overlays with PCIe
root complexes and when net-next re-opens, we should have a different
submission for you to look at then.
Thanks for your patience.
--
Florian
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]
next prev parent reply other threads:[~2024-05-14 16:19 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 0:03 [PATCH, net-next, 0/2] net: stmmac: support for BCM8958x SoC Jitendra Vegiraju
2024-05-10 0:03 ` [PATCH, net-next, 1/2] net: stmmac: Export dma_ops for reuse in glue drivers Jitendra Vegiraju
2024-05-10 0:03 ` [PATCH, net-next, 2/2] net: stmmac: PCI driver for BCM8958X SoC Jitendra Vegiraju
2024-05-11 1:35 ` Jakub Kicinski
2024-05-11 1:59 ` [PATCH v2, " Jitendra Vegiraju
2024-05-11 2:08 ` Jakub Kicinski
2024-05-13 16:47 ` Jitendra Vegiraju
2024-05-11 16:16 ` Andrew Lunn
2024-05-11 17:12 ` Russell King (Oracle)
2024-05-11 17:19 ` Andrew Lunn
2024-05-11 19:35 ` Russell King (Oracle)
2024-05-11 17:50 ` Andrew Lunn
2024-05-11 19:36 ` Russell King (Oracle)
2024-05-13 17:32 ` Jitendra Vegiraju
2024-05-13 18:07 ` Andrew Lunn
2024-05-14 8:19 ` Russell King (Oracle)
2024-05-14 16:18 ` Florian Fainelli [this message]
2024-05-11 19:34 ` Russell King (Oracle)
2024-05-13 17:38 ` Jitendra Vegiraju
2024-05-13 17:41 ` Russell King (Oracle)
2024-05-13 19:52 ` Andrew Lunn
2024-05-12 8:35 ` Simon Horman
2024-05-17 23:50 ` [PATCH, " kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2859e842-fe0b-4daf-b926-fa7db535b968@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jitendra.vegiraju@broadcom.com \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux@armlinux.org.uk \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).