From: Dave Jiang <dave.jiang@intel.com>
To: vishal.l.verma@intel.com
Cc: linux-cxl@vger.kernel.org, nvdimm@lists.linux.dev,
dan.j.williams@intel.com, yangx.jy@fujitsu.com
Subject: [NDCTL PATCH v3] cxl/region: Add -f option for disable-region
Date: Tue, 31 Oct 2023 14:20:45 -0700 [thread overview]
Message-ID: <169878724592.82931.11180459815481606425.stgit@djiang5-mobl3> (raw)
The current operation for disable-region does not check if the memory
covered by a region is online before attempting to disable the cxl region.
Have the tool attempt to offline the relevant memory before attempting to
disable the region(s). If offline fails, stop and return error.
Provide a -f option for the region to continue disable the region even if
the memory is not offlined. Add a warning to state that the physical
memory is being leaked and unrecoverable unless reboot due to disable without
offline.
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
---
v3:
- Remove movable check. (Dan)
- Attempt to offline if not offline. -f will disable region anyways even
if memory not offline. (Dan)
v2:
- Update documentation and help output. (Vishal)
---
Documentation/cxl/cxl-disable-region.txt | 10 ++++++
cxl/region.c | 54 +++++++++++++++++++++++++++++-
2 files changed, 63 insertions(+), 1 deletion(-)
diff --git a/Documentation/cxl/cxl-disable-region.txt b/Documentation/cxl/cxl-disable-region.txt
index 4b0625e40bf6..9abf19e96094 100644
--- a/Documentation/cxl/cxl-disable-region.txt
+++ b/Documentation/cxl/cxl-disable-region.txt
@@ -14,6 +14,10 @@ SYNOPSIS
include::region-description.txt[]
+If there are memory blocks that are still online, the operation will attempt to
+offline the relevant blocks. If the offlining fails, the operation fails when not
+using the -f (force) parameter.
+
EXAMPLE
-------
----
@@ -27,6 +31,12 @@ OPTIONS
-------
include::bus-option.txt[]
+-f::
+--force::
+ Attempt to disable-region even though memory cannot be offlined successfully.
+ Will emit warning that operation will permanently leak phiscal address space
+ and cannot be recovered until a reboot.
+
include::decoder-option.txt[]
include::debug-option.txt[]
diff --git a/cxl/region.c b/cxl/region.c
index bcd703956207..5cbbf2749e2d 100644
--- a/cxl/region.c
+++ b/cxl/region.c
@@ -14,6 +14,7 @@
#include <util/parse-options.h>
#include <ccan/minmax/minmax.h>
#include <ccan/short_types/short_types.h>
+#include <daxctl/libdaxctl.h>
#include "filter.h"
#include "json.h"
@@ -95,6 +96,8 @@ static const struct option enable_options[] = {
static const struct option disable_options[] = {
BASE_OPTIONS(),
+ OPT_BOOLEAN('f', "force", ¶m.force,
+ "attempt to offline memory before disabling the region"),
OPT_END(),
};
@@ -789,13 +792,62 @@ static int destroy_region(struct cxl_region *region)
return cxl_region_delete(region);
}
+static int disable_region(struct cxl_region *region)
+{
+ const char *devname = cxl_region_get_devname(region);
+ struct daxctl_region *dax_region;
+ struct daxctl_memory *mem;
+ struct daxctl_dev *dev;
+ int failed = 0, rc;
+
+ dax_region = cxl_region_get_daxctl_region(region);
+ if (!dax_region)
+ goto out;
+
+ daxctl_dev_foreach(dax_region, dev) {
+ mem = daxctl_dev_get_memory(dev);
+ if (!mem)
+ return -ENXIO;
+
+ /*
+ * If memory is still online and user wants to force it, attempt
+ * to offline it.
+ */
+ if (daxctl_memory_is_online(mem)) {
+ rc = daxctl_memory_offline(mem);
+ if (rc < 0) {
+ log_err(&rl, "%s: unable to offline %s: %s\n",
+ devname,
+ daxctl_dev_get_devname(dev),
+ strerror(abs(rc)));
+ if (!param.force)
+ return rc;
+
+ failed++;
+ }
+ }
+ }
+
+ if (failed) {
+ log_err(&rl, "%s: Forcing region disable without successful offline.\n",
+ devname);
+ log_err(&rl, "%s: Physical address space has now been permanently leaked.\n",
+ devname);
+ log_err(&rl, "%s: Leaked address cannot be recovered until a reboot.\n",
+ devname);
+ }
+
+out:
+ return cxl_region_disable(region);
+}
+
static int do_region_xable(struct cxl_region *region, enum region_actions action)
{
switch (action) {
case ACTION_ENABLE:
return cxl_region_enable(region);
case ACTION_DISABLE:
- return cxl_region_disable(region);
+ return disable_region(region);
case ACTION_DESTROY:
return destroy_region(region);
default:
next reply other threads:[~2023-10-31 21:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-31 21:20 Dave Jiang [this message]
2023-11-02 22:51 ` [NDCTL PATCH v3] cxl/region: Add -f option for disable-region Alison Schofield
2023-11-09 11:26 ` 回复: " Xiao Yang (Fujitsu)
2023-11-09 19:32 ` fan
2023-11-27 9:34 ` Cao, Quanquan/曹 全全
2023-11-27 17:13 ` Dave Jiang
2023-11-27 17:58 ` Verma, Vishal L
2023-11-27 23:28 ` Dave Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169878724592.82931.11180459815481606425.stgit@djiang5-mobl3 \
--to=dave.jiang@intel.com \
--cc=dan.j.williams@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=vishal.l.verma@intel.com \
--cc=yangx.jy@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).