From: Dave Jiang <dave.jiang@intel.com>
To: "Verma, Vishal L" <vishal.l.verma@intel.com>,
"caoqq@fujitsu.com" <caoqq@fujitsu.com>
Cc: "Williams, Dan J" <dan.j.williams@intel.com>,
"yangx.jy@fujitsu.com" <yangx.jy@fujitsu.com>,
"linux-cxl@vger.kernel.org" <linux-cxl@vger.kernel.org>,
"nvdimm@lists.linux.dev" <nvdimm@lists.linux.dev>
Subject: Re: [NDCTL PATCH v3] cxl/region: Add -f option for disable-region
Date: Mon, 27 Nov 2023 16:28:02 -0700 [thread overview]
Message-ID: <9b72eab1-2fb6-43b9-9858-7bf809f77c39@intel.com> (raw)
In-Reply-To: <47fede41b87c0686c3dfbc95bf7c2e21b84c5100.camel@intel.com>
On 11/27/23 10:58, Verma, Vishal L wrote:
> On Mon, 2023-11-27 at 10:13 -0700, Dave Jiang wrote:
>> On 11/27/23 02:34, Cao, Quanquan/曹 全全 wrote:
>>>
>>>
>>> 1.Assuming the user hasn't executed the 'cxl disable-region
>>> region0' command and directly runs 'cxl destroy-region region0 -f',
>>> using the 'disable_region(region)' function to first take the
>>> region offline and then disable it might be more user-friendly.
>>> 2.If the user executes the 'cxl disable-region region0' command but
>>> fails to take it offline successfully, then runs 'cxl destroy-
>>> region region0 -f', using the 'cxl_region_disable(region)' function
>>> to directly 'disable region' and then 'destroy region' would also
>>> be reasonable.
>>
>> To make the behavior consistent, I think we should use
>> disable_region() with the check for the destroy_region() path.
>>
>> What do you think Vishal?
>>>
> Yep agreed, using the new helper in destroy-region also makes sense. Do
> you want to send a new patch for this - I've already applied this
> series to the pending branch.
Yeah I can send a new patch.
prev parent reply other threads:[~2023-11-27 23:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-31 21:20 [NDCTL PATCH v3] cxl/region: Add -f option for disable-region Dave Jiang
2023-11-02 22:51 ` Alison Schofield
2023-11-09 11:26 ` 回复: " Xiao Yang (Fujitsu)
2023-11-09 19:32 ` fan
2023-11-27 9:34 ` Cao, Quanquan/曹 全全
2023-11-27 17:13 ` Dave Jiang
2023-11-27 17:58 ` Verma, Vishal L
2023-11-27 23:28 ` Dave Jiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b72eab1-2fb6-43b9-9858-7bf809f77c39@intel.com \
--to=dave.jiang@intel.com \
--cc=caoqq@fujitsu.com \
--cc=dan.j.williams@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=vishal.l.verma@intel.com \
--cc=yangx.jy@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).