From: Li Zhijian <lizhijian@fujitsu.com>
To: nvdimm@lists.linux.dev
Cc: linux-cxl@vger.kernel.org, Li Zhijian <lizhijian@fujitsu.com>
Subject: [ndctl PATCH 2/3] test/cxl-region-sysfs.sh: use operator '!=' to compare hexadecimal value
Date: Thu, 23 Nov 2023 10:30:57 +0800 [thread overview]
Message-ID: <20231123023058.2963551-2-lizhijian@fujitsu.com> (raw)
In-Reply-To: <20231123023058.2963551-1-lizhijian@fujitsu.com>
Fix errors:
line 111: [: 0x80000000: integer expression expected
line 112: [: 0x3ff110000000: integer expression expected
line 141: [: 0x80000000: integer expression expected
line 143: [: 0x3ff110000000: integer expression expected
Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
---
test/cxl-region-sysfs.sh | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/test/cxl-region-sysfs.sh b/test/cxl-region-sysfs.sh
index ded7aa1..89f21a3 100644
--- a/test/cxl-region-sysfs.sh
+++ b/test/cxl-region-sysfs.sh
@@ -108,8 +108,8 @@ do
sz=$(cat /sys/bus/cxl/devices/$i/size)
res=$(cat /sys/bus/cxl/devices/$i/start)
- [ $sz -ne $region_size ] && err "$LINENO: decoder: $i sz: $sz region_size: $region_size"
- [ $res -ne $region_base ] && err "$LINENO: decoder: $i base: $res region_base: $region_base"
+ [ "$sz" != "$region_size" ] && err "$LINENO: decoder: $i sz: $sz region_size: $region_size"
+ [ "$res" != "$region_base" ] && err "$LINENO: decoder: $i base: $res region_base: $region_base"
done
# validate all switch decoders have the correct settings
@@ -143,9 +143,9 @@ do
res=$(decimal_to_hex $(echo $decoder | jq -r ".resource"))
sz=$(decimal_to_hex $(echo $decoder | jq -r ".size"))
- [ $sz -ne $region_size ] && err \
+ [ "$sz" != "$region_size" ] && err \
"$LINENO: decoder: $i sz: $sz region_size: $region_size"
- [ $res -ne $region_base ] && err \
+ [ "$res" != "$region_base" ] && err \
"$LINENO: decoder: $i base: $res region_base: $region_base"
done
--
2.41.0
next prev parent reply other threads:[~2023-11-23 2:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-23 2:30 [ndctl PATCH 1/3] test/cxl-region-sysfs.sh: covert size and resource to hex before test Li Zhijian
2023-11-23 2:30 ` Li Zhijian [this message]
2023-12-06 21:35 ` [ndctl PATCH 2/3] test/cxl-region-sysfs.sh: use operator '!=' to compare hexadecimal value Dan Williams
2023-12-07 9:00 ` Zhijian Li (Fujitsu)
2023-11-23 2:30 ` [ndctl PATCH 3/3] test/cxl-region-sysfs.sh: Fix cxl-region-sysfs.sh: line 107: [: missing `]' Li Zhijian
2023-12-06 21:37 ` Dan Williams
2023-12-07 9:07 ` Zhijian Li (Fujitsu)
2023-12-06 21:31 ` [ndctl PATCH 1/3] test/cxl-region-sysfs.sh: covert size and resource to hex before test Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231123023058.2963551-2-lizhijian@fujitsu.com \
--to=lizhijian@fujitsu.com \
--cc=linux-cxl@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).