From: "Zhijian Li (Fujitsu)" <lizhijian@fujitsu.com>
To: Dan Williams <dan.j.williams@intel.com>,
"nvdimm@lists.linux.dev" <nvdimm@lists.linux.dev>
Cc: "linux-cxl@vger.kernel.org" <linux-cxl@vger.kernel.org>
Subject: Re: [ndctl PATCH 3/3] test/cxl-region-sysfs.sh: Fix cxl-region-sysfs.sh: line 107: [: missing `]'
Date: Thu, 7 Dec 2023 09:07:03 +0000 [thread overview]
Message-ID: <5d6c09b9-d041-4c6c-b338-f1b4657bfbe9@fujitsu.com> (raw)
In-Reply-To: <6570e9b1524e8_45e0129469@dwillia2-xfh.jf.intel.com.notmuch>
On 07/12/2023 05:37, Dan Williams wrote:
> Li Zhijian wrote:
>> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
>
> Please no patches with empty changelogs. Commentary on the impact of the
> change is always welcome.
>
> Otherwise change looks good to me, and I wonder why this error is only
> triggering now?
I have to say current condition checking 1) easily hides *BUG*
1) [ a -ne b ] && echo NG
Instead, 2) as below are more reliable.
2) [ a -eq b ] || echo NG
>
> Acked-by: Dan Williams <dan.j.williams@intel.com>
>
>> ---
>> test/cxl-region-sysfs.sh | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/test/cxl-region-sysfs.sh b/test/cxl-region-sysfs.sh
>> index 89f21a3..3878351 100644
>> --- a/test/cxl-region-sysfs.sh
>> +++ b/test/cxl-region-sysfs.sh
>> @@ -104,7 +104,7 @@ do
>> iw=$(cat /sys/bus/cxl/devices/$i/interleave_ways)
>> ig=$(cat /sys/bus/cxl/devices/$i/interleave_granularity)
>> [ $iw -ne $nr_targets ] && err "$LINENO: decoder: $i iw: $iw targets: $nr_targets"
>> - [ $ig -ne $r_ig] && err "$LINENO: decoder: $i ig: $ig root ig: $r_ig"
>> + [ $ig -ne $r_ig ] && err "$LINENO: decoder: $i ig: $ig root ig: $r_ig"
>>
>> sz=$(cat /sys/bus/cxl/devices/$i/size)
>> res=$(cat /sys/bus/cxl/devices/$i/start)
>> --
>> 2.41.0
>>
>>
>
>
next prev parent reply other threads:[~2023-12-07 9:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-23 2:30 [ndctl PATCH 1/3] test/cxl-region-sysfs.sh: covert size and resource to hex before test Li Zhijian
2023-11-23 2:30 ` [ndctl PATCH 2/3] test/cxl-region-sysfs.sh: use operator '!=' to compare hexadecimal value Li Zhijian
2023-12-06 21:35 ` Dan Williams
2023-12-07 9:00 ` Zhijian Li (Fujitsu)
2023-11-23 2:30 ` [ndctl PATCH 3/3] test/cxl-region-sysfs.sh: Fix cxl-region-sysfs.sh: line 107: [: missing `]' Li Zhijian
2023-12-06 21:37 ` Dan Williams
2023-12-07 9:07 ` Zhijian Li (Fujitsu) [this message]
2023-12-06 21:31 ` [ndctl PATCH 1/3] test/cxl-region-sysfs.sh: covert size and resource to hex before test Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d6c09b9-d041-4c6c-b338-f1b4657bfbe9@fujitsu.com \
--to=lizhijian@fujitsu.com \
--cc=dan.j.williams@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).