($INBOX_DIR/description missing)
 help / color / mirror / Atom feed
From: Ross Burton <Ross.Burton@arm.com>
To: "perceval.arenou@ptxtrimble.com" <perceval.arenou@ptxtrimble.com>
Cc: "openembedded-devel@lists.openembedded.org"
	<openembedded-devel@lists.openembedded.org>,
	Perceval Arenou <perceval.arenou@gmail.com>
Subject: Re: [oe] [meta-multimedia][PATCH] aravis: new recipe aravis is a vision library for genicam based cameras. aravis project allows to stream from genicam and GigE cameras
Date: Wed, 17 Apr 2024 14:54:55 +0000	[thread overview]
Message-ID: <C6D61636-5453-4887-9698-02228A8CC9C4@arm.com> (raw)
In-Reply-To: <20240417140412.87875-1-perceval.arenou@ptxtrimble.com>

On 17 Apr 2024, at 15:04, Perceval via lists.openembedded.org <perceval.arenou=ptxtrimble.com@lists.openembedded.org> wrote:
> +DEPENDS += "\
> + glib-2.0 \
> + glib-2.0-native \
> + intltool-native \
> + libxml2 \
> + zlib \
> +"

Considering this uses Meson, I’m surprised this uses intltool.  Is this still valid?

> +S = "${WORKDIR}/${BPN}-${PV}"

This is the default, remove.

> +PACKAGECONFIG ?= ""
> +PACKAGECONFIG[gstreamer] = "-Dgst-plugin=enabled, -Dgst-plugin=disabled, gstreamer1.0 gstreamer1.0-plugins-base,"
> +PACKAGECONFIG[introspection] = "-Dintrospection=enabled, -Dintrospection=disabled, gobject-introspection,"
> +PACKAGECONFIG[usb] = "-Dusb=enabled, -Dusb=disabled, libusb1,"
> +PACKAGECONFIG[viewer] = "-Dviewer=enabled, -Dviewer=disabled, gtk+3 gstreamer1.0-plugins-base,"

I’d suggest enabling more things by default, so they get tested.

> +# needs to be after PACKAGECONFIG to make sure it is defined
> +inherit meson pkgconfig ${@bb.utils.contains('PACKAGECONFIG', 'introspection', 'gobject-introspection', '', d)}

Use inherit_defer to solve this problem.

Ross

  reply	other threads:[~2024-04-17 14:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-17 14:04 [meta-multimedia][PATCH] aravis: new recipe aravis is a vision library for genicam based cameras. aravis project allows to stream from genicam and GigE cameras perceval.arenou
2024-04-17 14:54 ` Ross Burton [this message]
     [not found] <17C71645B7063D93.20815@lists.openembedded.org>
2024-04-19 14:58 ` [External] [oe] " Perceval Arenou
2024-04-19 15:39   ` Ross Burton
2024-04-19 17:20     ` [External] " Perceval Arenou
2024-04-22  6:17       ` Martin Jansa
     [not found]       ` <17C885AD767F090E.10861@lists.openembedded.org>
2024-04-22  7:06         ` Martin Jansa
     [not found]           ` <17C976F30B799D6D.19690@lists.openembedded.org>
2024-04-25  8:04             ` [External] " Perceval Arenou
2024-04-26  3:02               ` Khem Raj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C6D61636-5453-4887-9698-02228A8CC9C4@arm.com \
    --to=ross.burton@arm.com \
    --cc=openembedded-devel@lists.openembedded.org \
    --cc=perceval.arenou@gmail.com \
    --cc=perceval.arenou@ptxtrimble.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).